Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I had the issue, that I couldn't save a bibliographic reference. Pressing "Save" would just do nothing.
I solved this problem by opening the DevTools (using Chromium). An Error "An invalid form control with name='bibcite_notes[0][value]' is not focusable." appeared. (Didn't get a message with Firefox Developer Tools though.)
Turns out, with this particular publication type, the "Notes" field was set to required. But as it was not visible right now (wrong Tab selected), so it couldn't inform the user.
If I select the tab with the Notes field, the error message appears as expected.
I would expect that the tab in question should open, so that the message could be shown to the user.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3006174-7-reference-required.patch | 3.24 KB | ebremner |
| |||
Comments
Comment #2
antongp CreditAttribution: antongp at ADCI Solutions commentedHi. There is open issue in Drupal core: #1797438: HTML5 validation is preventing form submit and not fully accessible. Also, there are related issues in Field Group module like #2969051: HTML5 Validation Prevents Submission in Tabs and #2787179: Ensure visibility of invalid fields (JS) , and in some other modules as well. It's more likely that no fix will be needed once those issues are fixed. But let's leave this issue in "Postponed" and keep track on those issues to be sure.
Comment #3
antongp CreditAttribution: antongp at ADCI Solutions commentedComment #4
Rafael CansinosThe problem is still there. If there is a mandatory field and you save it does not warn that there is a required field. It does not save, nothing happens, and you have to find the field that must be filled in. It should return a message like "Name of the field. The field is required".
I have installed Drupal core 8.8.5 and recent Bibcite Development version: 8.x-1.x-dev updated 30 Mar 2020.
Excellent module! I come from the module Biblio. It gave me errors. They were not serious but annoying. Now with Drupal 8 & Bibcite it works perfectly. Thank you.
Comment #5
koffer CreditAttribution: koffer as a volunteer and commentedMay be a provisional solution could be add a description field to inform about this problem (check the mandatory field are fill or you cant save the reference).
It is a little dirt solution, but give some information to users.
Comment #6
Corn696The patch from the field group module works with my "normal" forms. Only the bibcite forms aren't working.
The bibcite module overrides the form displays and build the field groups programmatically maybe something is missing in the override?
The tabs aren't marked as required as well.
Comment #7
ebremner CreditAttribution: ebremner at University of Waterloo commentedHere is at least a patch that will show which tabs have required fields, not the perfect solution, but at least allows users to see what is required.