Make accesslog storage pluggable [#1880494]

Similar to how watchdog entries can be stored in the db via dblog or flat system log files via syslog, I think it'd be great to allow arbitrary storage of Statistics API data. Maybe provide an optional sub-module that is syslog-like.

Comment	File	Size	Author
#8	better_statistics-pluggable_accesslog_storage-1880494-7.patch	4 KB	iamEAP
#8
#7	better_statistics-pluggable_accesslog_storage-1880494-7.patch	4 KB	iamEAP
#7
#5	better_statistics-pluggable_accesslog_storage-1880494-5.patch	4.04 KB	iamEAP
#5
#3	better_statistics-pluggable_accesslog_storage-1880494-3.patch	4.04 KB	iamEAP
#3
#1	better_statistics-pluggable_accesslog_storage-1880494-1.patch	3.92 KB	iamEAP
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

iamEAP CreditAttribution: iamEAP commented 3 March 2013 at 07:21

Status:

Active

» Needs review

File	Size
better_statistics-pluggable_accesslog_storage-1880494-1.patch	3.92 KB

Rather than adding the syslog-like functionality here, I'll leave that open elsewhere. This introduces the capability via hook_better_statistics_log(), which behaves more or less exactly like hook_watchdog().

Also added a somewhat contrived example and documentation to better_statistics.api.php.

Comment #2

mondrake

🇮🇹

CreditAttribution: mondrake commented 4 March 2013 at 08:08

Looks fine to me.

The plugin integration for ip_geoloc has a feature to 'rewrite' part of the information that was logged already (the geolocation information comes asychronously after the page hit, so I run an update against all the log entries that occurred since the geolocation request). It is key for the module to understand what storage is being used - if not db, then the log entries may not be rewriteable.

So I like the idea of the 'statistics_log_to_db' variable.

It can be RTBCed for me, I just wonder if more reviews can be expected.

Comment #3

iamEAP CreditAttribution: iamEAP commented 5 March 2013 at 00:40

File	Size
better_statistics-pluggable_accesslog_storage-1880494-3.patch	4.04 KB

Thanks, Mondrake. Noticed I made one small error in the the hook_better_statistics_log() implementation; fixed here. I doubt there will be many other reviews, so if Testbot likes this, I'll commit.