I have this warning message when overriding default order of formats for field comment

Strict warning: Only variables should be passed by reference w better_formats_filter_process_format() (line 132 in ...\sites\all\modules\better_formats\better_formats.module).

CommentFileSizeAuthor
#13 better_format-n1717470-11.patch493 bytesAexChecker
#11 better_format-strict-warning-1717470-11.patch553 bytesmbruneel
#2 fix_var_ref_message-1717470-1.patch0 bytesmathieso
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

milley’s picture

milley CreditAttribution: milley commented
Title: Strict warning when override order of formats in comments » Strict warning when override order of formats

When I add new content with reordered formats for some field I also have this warning.

mathieso’s picture

mathieso CreditAttribution: mathieso commented
FileSize
fix_var_ref_message-1717470-1.patch0 bytes

This patch should fix it.

Note: I'm still learning about patch files. Please let me know if aught is wrong. The changes are at line 132, replacing ...

$element['format']['format']['#default_value'] = array_shift(array_keys($options));

... with ...

$options_keys = array_keys($options);
$element['format']['format']['#default_value'] = array_shift($options_keys);

Kieran

meridiandigital’s picture

meridiandigital CreditAttribution: meridiandigital commented
Status: Active » Reviewed & tested by the community

Confirm patch works as advertised.

drupov’s picture

drupov CreditAttribution: drupov commented

Patch works for me too.

dragonwize’s picture

dragonwize CreditAttribution: dragonwize commented
Status: Reviewed & tested by the community » Fixed

Thanks. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

wylbur’s picture

wylbur CreditAttribution: wylbur commented
Status: Closed (fixed) » Needs work

This is still an issue when using PHP 5.4. Drupal reports this error when you change the default sort order of formats.

The patch listed in comment #2 does not work as it is a zero length file.

I applied the changes to the file, and that resolved the error for me. This is ready for rolling a real patch and testing.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Status: Needs work » Closed (fixed)

It's been fixed in 7.x-1.x-dev. beta1 still has the broken code. You need to upgrade to the latest dev (or wait for beta2 to come out).

Weird that that patch file is empty. Here's the commit that's in Git that fixes the bug:

http://drupalcode.org/project/better_formats.git/commitdiff/ca0822a

Good luck,
-Derek

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody commented
Issue summary: View changes

This fix is now very old but the problem still exists in the latest version. Is it possible to release a new beta version soon to have this fixed? It should not get worse by that but you would make many people happy :)

edachan’s picture

edachan CreditAttribution: edachan commented

Solution at https://www.drupal.org/node/2194237#comment-9501869

mbruneel’s picture

mbruneel CreditAttribution: mbruneel commented
FileSize
better_format-strict-warning-1717470-11.patch553 bytes
drupov’s picture

drupov CreditAttribution: drupov commented

As stated in #8 if you use latest dev, the error should not appear.

AexChecker’s picture

AexChecker CreditAttribution: AexChecker as a volunteer commented
Status: Closed (fixed) » Needs review
FileSize
better_format-n1717470-11.patch493 bytes
Chipie’s picture

Chipie CreditAttribution: Chipie commented

#13 works for me

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

Looks like this was fixed in the dev version: http://cgit.drupalcode.org/better_formats/commit/?h=7.x-1.x&id=ca0822a94...

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody as a volunteer and commented

Please create a new stable release. This is still unfixed in the latest stable, which is very sad. The .dev is well tested and OK!

Any active maintainer here?

tregismoreira’s picture

tregismoreira CreditAttribution: tregismoreira commented

#13 works for me. Thanks! :)

steveoriol’s picture

steveoriol
Location Grenoble 🇫🇷
CreditAttribution: steveoriol commented

#13 works for me too. Thanks! :-)