Fix 7.x branch tests

We should also add the modules to the 'dependencies' key in the getInfo() module, so it doesn't break with missing dependencies when testing locally.

Updated patch

And back to Needs Review...

The patch fails because there are no tests found to be executed: test_dependencies[] is not added until after dependencies are downloaded by the testbot, and the tests are skipped because date is not installed. I believe it is ready to commit though, so back to 'Needs review'.

@Stevel, you've fixed tests for other modules in the past, great work.

Would be nice if someone would step up to maintain this project.

@joseph.olstad I do not want to sound defensive, but there ARE people trying to maintain this module, we are just busy.
Please read the bottom of the project page to understand the circumstance.
As always, we welcome assistance from anyone in the community, and we appreciate all the efforts so far.

Yes other maintainers have died of cancer and the project lives on.
Like media.
If stevel says this is ready for commit it should be committed . Chicken and the egg here. Stevel has fixed other projects tests and has a good reputation. His explanation makes sense.

Hoping a maintainer can step up here.

I believe the next step here is to get community review. @joseph.olstad if you can take the time to do that that would be great, I'll also take a look later this week when I have time. If we can get the community to step up and get this RTBC then I'm sure the hard working maintainers will happily commit it.

This looks like an improvement. I'm going to commit the patch and see how the tests do.

Thanks!
seems to be an improvement.
php 5.3 seems to have better results in the automated tests
5.6 gets stuck on setUp and that is the most important step. php 5.3 gets past setUp without error.

Tests are still failing, so this needs work?

I see that we are missing Features as test dependency because the bef_test_content module depends on it. Then the 2 remaining test fails are fixed for me.

Hm, looking at https://dispatcher.drupalci.org/job/drupal_d7/111060/console is seems DrupalCI downloads test dependencies before fetching/applying the patch, so Features module is not downloaded, so we have the same test fails.

I guess we have to commit this blindly and then check again if DrupalCI picks it up?

That sounds good. I'll commit the patch and we'll see if that fixes the tests.

OK, that is progress ... down to a couple of test fails in BEF_TestLinks.

I fixed the obvious ones with the URL encoding. Now 1 fail remains where the test expects a "?status_1=0" URL, but the query is omitted for the filter. Maybe that is a new feature in the module, we need to check if that is intentional.

Hrmpf, that did not help - somehow the testbot still shows the same test fails as the dev branch.

How can we find out why the XPath expression fails on the testbot but not locally for me?

And the tests are broken on PHP 7.2, but It seems like a Views issue.

OK, since I'm not sure how those assertions should be changed I have disabled them for now. The important thing here is to get the branch to pass the tests again, so that other patches can be tested. We can enable the assertions again in a new issue for BEF Links.

Passing tests, yay!

I think we can commit this now and then open a new issue about fixing the assertions for BEF Links.

nice, thanks Klausi!

Thanks, everyone.

there were three commit messages above, maybe some gaffe there?

hmm, project automated tests still need work for php 7.2.x and php 5.3.x it looks like

I wanted to give author credit to everyone who helped produce the final patch that got committed, hence the three commits.

The tests are failing because the Views security release uses short array syntax, which is a test dependency. So we need to wait on the next Views release, see #3039953: PHP 5.3.x fix for syntax changes Views 3.21. Then the branch should also pass on PHP 7, the errors there are related to #2810431: Parameter 3 to views_ui_build_form_state() expected to be a reference, value given in views_ui_ajax_form() (also not released yet).

@rlhawk can you set the issue test default to something other than php 5.3.x ?
and add commit tests for php 7.0.x , 7.1.x , 7.2.x (supported by core) and php 7.3.x (soon supported in core)

currently php 5.3.x is the issue default automated test, I recommend something higher than that for the default. Currently the lowest zend supported release is php 7.1.x.

Thanks