Problem/Motivation
These two errors (both in beautytips_manager.module) are logged:
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "path.alias_manager.cached". Did you mean this: "path.alias_manager"?
Line 214: ArgumentCountError: Too few arguments to function Drupal\Component\Render\FormattableMarkup::__construct(), 1 passed
Steps to reproduce
Install module, add a new Custom Tip. Assign it to only render on a certain page. The code with the call to Drupal::service('path.alias_manager.cached') is only executed when a tip is defined to be limited to certain pages.
Proposed resolution
I have the start of a patch attached.
Remaining tasks
The code to match the path of the tooltip isn't quite right yet. This patch does get it to function for tooltips not specifying a path.
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | beautytips-3187417-6.patch | 1.78 KB | pamelalies |
| #5 | beautytips-3187417-5.patch | 1.55 KB | pamelalies |
| #4 | beautytips-3187417-4.patch | 1.51 KB | pamelalies |
| #3 | beautytips-3187417.patch | 1.91 KB | pamelalies |
| #2 | beautytips-3187417.patch | 1.91 KB | pamelalies |
Issue fork beautytips-3187417
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
pamelalies commentedComment #3
pamelalies commentedSorry, that was my local version of the file!
Comment #4
pamelalies commented3rd times a charm, hopefully.
Comment #5
pamelalies commentedOr not!
Comment #6
pamelalies commentedThis patch also strips any leading slash from the path of the current page, since the admin page for adding a custom tip specifies not to include a leading slash when configuring to which pages to add the tip.
Comment #9
chaitanyadessai commentedPlease review.