In _navigation.scss there are styles for #navigation, which doesn't exist as an html object. There are also references in _layout--grid.scss to a "navigation menus" that get loaded after "content", but my main nav block is in my header with no nav section to put it in. Is there something I am missing? How did we end up with these unused references. SEO is of dire importance for this project, so I want to make sure I am using this properly.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | added-navigation-region-3025201-5.patch | 1.02 KB | maithri shetty |
| #3 | added-navigation-region-3025201-3.patch | 1.38 KB | maithri shetty |
Comments
Comment #2
ebren commentedComment #3
maithri shetty commentedAdded navigation region.
Comment #4
joelpittetThe patch has two navigation regions. And not using the sass files for the css.
Regarding how the references got there, likely ported from Drupal 7 or a core file in D8.
There shouldn’t need a region explicit to navigation, ideally the menu block should work well as a design component where ever it is placed. But in your project if you need a region, by all means add it.
We should remove those references though, thanks for the heads up
Comment #5
maithri shetty commentedAdded Navigation region.
Comment #6
awasson commentedThis is related to issue:
Primary/Secondary Menu Regions (2901386)
I'm going to leave it as postponed until we decide on that one. If we do choose to go ahead with the related issue, then #navigation css will be valid.
Cheers,
Andrew
Comment #7
awasson commentedFor lack of a better Status, I have closed as duplicate and this should be handled by the related issue, which I just applied.
Thanks all.
Cheers,
Andrew