Fieldset backgrounds extend above legends in IE

Possible fix, needs review and testing (tested in IE7, FF3.6, Chrome).

Another possibility and perhaps more simple is to use a background image and position it (like Garland does).

set status, doh...

Bumpity bump - languishing for a few weeks now, anyone up for a review?

The problem with this is that is looks crappy when the background is not white. See screenshot. Maybe the background image would be better?

Also, this patch is changing the background color for the fieldset from #fbfbfb to #fafafa, and then the legend is #fff... Typo?

Typo? Probably, I cant remember, its was written in about 30 seconds as proof of concept patch.

I'll put some more thought into it, I have a few ideas for taking the whole fieldset styling up another notch.

Well heres a different approach altogether - heavy styling of the legend and fieldsets.

This won't work so well in RTL in IE because it relys on there being an ie-rtl.css file, which I have already submitted a patch for tabs #784312: Tabs in IE need love, especially RTL that demands this file also (frankly we need it anyway, its going to be useful).

Screeny shows a bunch of various fieldsets + legends, if we go this route I think we need to replace the arrows with white ones.

Wow Jeff, this is really good work in #7! Massive improvement over the previous look of the legends in my opinion. Definitely would like to get some more eyes on this, and possible get this committed soon.

I have taking it through some testing in IE6-8 and every looks like it functioning as it should be, a really great look.

Keep up the awesome work.

Unassigned - on vacation for the next week!

Can someone pick this up, would be nice to have groovy fieldset styles.

@ Jeff - I've got quite a bit of free time from now through the 12th. I'll take your work from #7 and see what I can do to improve on it, run it through more testing and experimentation.

So I have been taking Jeff's patch from #7 through some testing, everything is looking pretty great, but I am noticing minor differences across different browsers. I have tested it in Firefox, Chrome, IE6-8, and Safari - Vista. It looks nearly the in Firefox and IE(7) (minus border radius), but looks a little different in the other browsers, but all the other browsers look nearly the same.

I attached two screenshots of what I am talking about. One, what it looks like in Firefox and the other what it looks in most other browsers I tested it in. It isn't it major difference, but probably a difference that shouldn't be there. I am going to keep working on this and see if I can make it look more consistent across all browsers. Feel free to chime in if you have any ideas.

I am going to unassign myself issue, going to be busy with a client project the next couple days and don't think I will have much time to work on it. I still am not able to resolve the problems discussed in #11.

This patch fixes the patch in #7 to work cross-browser. I never thought it would be FF to complain while IE6 works fine. It was like wrestling an aligator. For reference, in FF legends are effected by the left/right padding of the fieldset.

This patch has been tested in FF3.6, Safarai 4, Chrome5, IE6, IE7 & IE8 and they all look like this (except for rounded corners):

Every thing looks pretty good, there is now constancy cross browser. But, there are still some problems with IE6-7 when in RTL. See screenshot.

Friggin IE ... on it

ok ... this patch looks good in RTL too :)

This looks really great bleen, just super work. Tested it in Ff, Chrome, Safari, and IE6-8 and carries consistency.

Just one small change I'd like to make. It may just be personal taste, but I don't really think the pinkish-red color on the fieldset anchor links for there hover state matches Bartik's default color scheme. I made a subtle to white for the anchor links natural state, and a grayish for hover.

The attached patch includes the work from #16 and the small change to the fieldset anchor links described.

Looks good to me ... One more review for good luck so we can mark this RTBC

The patch isn't applying properly...

something changed in style.css ... rerolling

rerolled

This latest patch looks good. Tested in IE6-8, Ff, and Safari and Chrome. Looks great both with overlays and without.

I think the fieldset-wrapper needs some more margin or padding top, items tend to sit very close to the legend in Firefox. Other than that its looking good.

fair enough ... tweaked based on #23

Looks good to me.

Ok, I used the patch in 23, and changed up some of the colors. Everything else is the same.

I went with the light text on dark background for a while, and had a whole other look going... but in the end, I felt like the dark header was too strong and make that text look much more important than it is. So I went with a light backkground and darker text. Looks much more Bartik to me.

Committed.

Core blimey, I think those look great Jen, nice work peps.

I found one place in which this borks out, its when you have Seven set as the Admin theme and are in the overlay for theme settings for Bartik (phew, what a mouthful).

Seven sets a 2.5em padding-top for fieldsets.

See the screenshot:

Removed because this comment was inaccurate

this should do it

Committed.

Works for me. I added a comment above the two new rules to explain why they're needed.

This wasn't committed, actually. The commit aborted, and I didn't see the error message until now.

heh. I think we committed at the same time. Mine must have gone in just before your CVS error.