Fix performance coverage for Node preview component CSS style loaded for anonymous users [#3209709]

Problem/Motivation

Having a performance coverage issue of 100% not used CSS from the

Node preview component CSS style

node.preview.css
On anonymous users or when not previewing a node

Steps to reproduce

Switch off CSS and JavaScript aggregation and advanced aggregations
Find Unused JavaScript And CSS With The Coverage Tab

Proposed resolution

Load only on node preview for logged in users
The Drupal core node module has a drupal.node.preview but themes are not overriding or extending the library

drupal.node.preview:
  version: VERSION
  css:
    theme:
      css/node.preview.css: {}
  js:
    node.preview.js: {}
  dependencies:
    - core/jquery
    - core/jquery.once
    - core/drupal
    - core/drupal.dialog
    - core/drupal.form

The Stable Drupal core theme is doing

libraries-override:
  node/drupal.node.preview:
    css:
      theme:
        css/node.preview.css: css/node/node.preview.css

The Olivero Drupal core front-end theme is doing

libraries-extend:
  node/drupal.node.preview:
    - olivero/drupal.node.preview

Having the Olivero libraries extend way

Remaining tasks

Fix
Performance coverage test
Functional test
Review
Release

User interface changes

None

API changes

None

Data model changes

None

Comment	File	Size	Author
#2	3209709-2.patch	1.19 KB	rajab natshah

Issue fork bartik-3209709

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3209709-fix-preview-component changes, plain diff MR !13
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

20 April 2021 at 10:03

RajabNatshah created an issue. See original summary.

Comment #2

rajab natshah

he/him

commented 20 April 2021 at 10:11

Status	File	Size
new	3209709-2.patch	1.19 KB

Comment #3

rajab natshah

he/him

commented 20 April 2021 at 10:12

Assigned:	rajab natshah	» Unassigned
Status:	Active	» Needs review
Issue tags:		+Page loading performance, +Performance, +performance coverage

Comment #4

20 April 2021 at 10:12

Version:

9.1.x-dev

» 9.3.x-dev

Drupal 9.1.10 (June 4, 2021) and Drupal 9.2.10 (November 24, 2021) were the last bugfix releases of those minor version series. Drupal 9 bug reports should be targeted for the 9.3.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #5

vikashsoni commented 13 January 2022 at 11:05

@RajabNatshah tested and verify patch
thanks for the patch

Comment #6

13 January 2022 at 11:05

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #7

smustgrave commented 14 December 2022 at 00:43

Project:	Drupal core	» Bartik
Version:	9.4.x-dev	» 1.0.2
Component:	Bartik theme	» Look and Feel

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 200, following Review a patch or merge require as a guide.

Thank you for the work on this!

This appears to be very specific to the bartik theme and unfortunately bartik has been removed in Drupal 10 and moved to contrib project. So moving to over there will hopefully it will have a better chance.