Removing credit for #25, #18, #15 (those are literally the same videos that were renamed from an earlier comment), #14

All provide screenshots/videos that do not offer anything in addition to what was already provided in earlier comments.

The issue summary is currently empty, so that needs updating too.

CommentFileSizeAuthor
#25 3196784--after--patch--pic.png34.1 KBvikashsoni
#25 3196784--before--pic.png34.69 KBvikashsoni
#24 After Patch 3196784 RTL Mobile.png405.42 KBchetanbharambe
#24 After Patch 3196784 RTL Desktop.png412.92 KBchetanbharambe
#24 After Patch 3196784 Mobile.png230.56 KBchetanbharambe
#24 After Patch 3196784 Desktop.png290.42 KBchetanbharambe
#24 Before Patch 3196784 Mobile.png253.43 KBchetanbharambe
#24 Before Patch 3196784 Desktop.png325.63 KBchetanbharambe
#18 after.png48.43 KBrinku jacob 13
#18 before.png48.61 KBrinku jacob 13
#15 before.mp41.91 MBradheymkumar
#15 after.mp41.78 MBradheymkumar
#14 after_3196784_14.png6.81 KBkleiton_rodrigues
#14 before_3196784_14.png7.82 KBkleiton_rodrigues
#12 3196784-RTL-after-patch.png27.03 KBindrajithkb
#12 3196784-RTL.png26.6 KBindrajithkb
#12 interdiff_6-12.txt364 bytesindrajithkb
#12 3196784-12.patch517 bytesindrajithkb
#9 After-patch.png87.78 KBsakthivel m
#9 Before-patch.png87.81 KBsakthivel m
#8 3196784-after.mp41.78 MBabhijith s
#8 3196784-before.mp41.91 MBabhijith s
#6 3196784-6.patch413 bytesgauravvvv
#5 Screen Shot 2021-02-18 at 2.52.04 PM.png249.1 KBdjsagar
#5 Screen Shot 2021-02-18 at 2.51.55 PM.png223.49 KBdjsagar
#5 Screen Shot 2021-02-18 at 2.51.46 PM.png249.25 KBdjsagar
#2 Screenshot 2021-02-12 at 11.20.16.png323.15 KBgauravvvv
#2 Screenshot 2021-02-12 at 11.20.24.png49.13 KBgauravvvv
#2 3196784-2.patch408 bytesgauravvvv
Tab-768.png59.51 KBdjsagar
mobile-414.png69.05 KBdjsagar
mobile-320.png59.63 KBdjsagar
desktop.png60.25 KBdjsagar
issue-video.mp411.99 MBdjsagar

Issue fork drupal-3196784

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

djsagar created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Issue summary: View changes
StatusFileSize
new 3196784-2.patch408 bytes
new Screenshot 2021-02-12 at 11.20.24.png49.13 KB
new Screenshot 2021-02-12 at 11.20.16.png323.15 KB
gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
gauravvvv’s picture

gauravvvv commented
Issue summary: View changes

I have provided the patch, I have decreased the font-size of the input field to its normal, Which was scaling for screen size below 60em. I have attached an after patch screenshot.

djsagar’s picture

djsagar commented
Status: Needs review » Needs work
StatusFileSize
new Screen Shot 2021-02-18 at 2.51.46 PM.png249.25 KB
new Screen Shot 2021-02-18 at 2.51.55 PM.png223.49 KB
new Screen Shot 2021-02-18 at 2.52.04 PM.png249.1 KB

Hi @Gauravmahlawat,

NO need to change font, just remove the float property.

For more info please see the attachment.

Thanks!

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3196784-6.patch413 bytes

Patch attached.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
abhijith s’s picture

abhijith s commented
StatusFileSize
new 3196784-before.mp41.91 MB
new 3196784-after.mp41.78 MB

Applied patch #6 and it works fine.

RTBC +1

sakthivel m’s picture

sakthivel m commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before-patch.png87.81 KB
new After-patch.png87.78 KB

Patch #6 successfully applied.

Before
Before

After
After

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/themes/bartik/css/components/search-form.css
@@ -7,7 +7,6 @@
-  float: left; /* LTR */

Given that this line has the LTR comment, there is likely a RTL style for this. Let's make sure that's adjusted too, and that this gets tested in RTL as well.

indrajithkb’s picture

indrajithkb commented
Status: Needs work » Needs review
StatusFileSize
new 3196784-12.patch517 bytes
new interdiff_6-12.txt364 bytes
new 3196784-RTL.png26.6 KB
new 3196784-RTL-after-patch.png27.03 KB

Hi @Gauravmahlawat thanks for the #6 patch.
@lauriii i have tested patch for the RTL , we can see the issue is there,
attaching the SS and adding the patch. Please review

SS for RTL
image

After fix RTL:

image

kleiton_rodrigues’s picture

kleiton_rodrigues commented
Assigned: Unassigned » kleiton_rodrigues
kleiton_rodrigues’s picture

kleiton_rodrigues commented
Assigned: kleiton_rodrigues » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_3196784_14.png7.82 KB
new after_3196784_14.png6.81 KB

patch 12 applied, it looks good!
moving to RTBC

radheymkumar’s picture

radheymkumar commented
StatusFileSize
new after.mp41.78 MB
new before.mp41.91 MB

Patch #6 working fine
sharing video

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 12: 3196784-12.patch, failed testing. View results

atul4drupal’s picture

atul4drupal commented
Status: Needs work » Reviewed & tested by the community

Changing Back to RTBC. Smart BoT's :)

rinku jacob 13’s picture

rinku jacob 13 commented
StatusFileSize
new before.png48.61 KB
new after.png48.43 KB

patch #6 applied successfully for drupal 9.3.x-dev

kleiton_rodrigues’s picture

kleiton_rodrigues commented
Assigned: Unassigned » kleiton_rodrigues
kleiton_rodrigues’s picture

kleiton_rodrigues commented
Assigned: kleiton_rodrigues » Unassigned

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 12: 3196784-12.patch, failed testing. View results

Indrajith KB opened merge request !1061

indrajithkb’s picture

indrajithkb commented
Status: Needs work » Needs review

Added the MR, Please review the issue.

chetanbharambe’s picture

chetanbharambe commented
Status: Needs review » Needs work
StatusFileSize
new Before Patch 3196784 Desktop.png325.63 KB
new Before Patch 3196784 Mobile.png253.43 KB
new After Patch 3196784 Desktop.png290.42 KB
new After Patch 3196784 Mobile.png230.56 KB
new After Patch 3196784 RTL Desktop.png412.92 KB
new After Patch 3196784 RTL Mobile.png405.42 KB

Hi @Indrajith KB,
Verified and tested merge request !1061 (https://git.drupalcode.org/project/drupal/-/merge_requests/1061.patch)
Merge request applied successfully but not working as expected.

Testing Steps:
# Goto: Appearance -> Apply Bartik theme
# Goto Homepage -> Search any keyword in the search result
# Observe the results

Expected Results:
# User should see "about searching" text should be aligned properly for LTR and RTL.

Actual Results:
# Currently, the User is able to see "about searching" text is broken on desktop and responsiveness for LTR and RTL.

Please refer attached screenshots for the same.
Not working as Expected
Can be a move to Needs Work.

vikashsoni’s picture

vikashsoni commented
StatusFileSize
new 3196784--before--pic.png34.69 KB
new 3196784--after--patch--pic.png34.1 KB

Applied patch #6 applied successfully in drupal-9.3.x-dev
Thanks for the patch
For ref sharing screenshots...

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Issue summary: View changes
Issue tags: +Needs issue summary update

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

pameeela’s picture

pameeela commented
Project: Drupal core » Bartik
Version: 10.1.x-dev » 1.0.2
Component: Bartik theme » Look and Feel
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +Bug Smash Initiative

Moving to contrib since this only touches Bartik, which was removed in D10.

Still definitely needs an issue summary to explain what problem is being addressed, I have no idea what the issue is, but the MR is just two small CSS changes. No idea how people are reviewing and testing this without knowing what the problem is!

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 1.0.2 » 1.1.x-dev
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

You may re-open this and provide steps to reproduce the problem.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.