Problem/Motivation

When returns large text status. Bartik theme returns a scroller {bottom} in the site, which is not good.

Steps to reproduce

Login Drupal9
Install Calendar Module
Create a view page using a calendar display.
Go to that page.
Flush cache.

Proposed resolution

The status section should have its own area with a scroller, not in the entire site, which is breaking the design.

Remaining tasks

Created a patch.
Need Review.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#38 interdiff_36-38.txt6 KBvsujeetkumar
#38 3193918-38.patch9.17 KBvsujeetkumar
#36 interdiff_3193918_34-36.txt789 bytesankithashetty
#36 3193918-36.patch2.77 KBankithashetty
#34 3193918-34.patch2.86 KBbhumikavarshney
#32 3193918-32.patch653 bytesgauravvvv
#29 3193918-28.patch653 bytesdjsagar
#28 interdiff-3193918-25-28.txt644 bytesabhisekmazumdar
#28 3193918-28.patch648 bytesabhisekmazumdar
#25 rerolled-3193918-25.patch562 bytesgauravvvv
#23 3193918-23.patch542 bytesgauravvvv
#21 3193918-20.patch429 bytesdjsagar
#19 3193918-19.patch486 bytesranjith_kumar_k_u
#18 3193918-18.patch486 bytesdjsagar
#16 3193918-16.patch429 bytesdjsagar
#14 bartik_status_design_issue_14.patch472 byteskumar ashutosh
#13 bartik_status_design_issue_1_13.patch395 byteskumar ashutosh
#13 bartik_status_design_issue_1_13.txt293 byteskumar ashutosh
#12 3193918-12.patch416 bytesnishat ahmad
#11 3193918-5-patch.png46.49 KBdjsagar
#11 3193918-6-patch.png45.35 KBdjsagar
#11 3193918-7-patch.png41.98 KBdjsagar
#9 3193918-9.patch391 bytesnishat ahmad
#8 3193918-7.patch391 bytesabhijith s
#6 3193918-6.patch412 bytessulfikar_s
#5 3193918-5.patch429 bytesravi.shankar
bartik_status_design_issue.patch434 byteskumar ashutosh
after-patch.png37.77 KBkumar ashutosh
before-patch.png59.64 KBkumar ashutosh

Issue fork drupal-3193918

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Issue fork bartik-3193918

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Kumar Ashutosh created an issue. See original summary.

djsagar’s picture

djsagar commented
Assigned: kumar ashutosh » Unassigned
djsagar’s picture

djsagar commented
Status: Needs review » Needs work

Custom Commands Failed please re-work.

Nishat Ahmad made their first commit to this issue’s fork.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3193918-5.patch429 bytes

This patch might fix comment #3.

sulfikar_s’s picture

sulfikar_s commented
StatusFileSize
new 3193918-6.patch412 bytes

Hi, I've fixed the Custom Commands issue in my patch.

Please review!

Status: Needs review » Needs work

The last submitted patch, 6: 3193918-6.patch, failed testing. View results

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3193918-7.patch391 bytes

Fixed the fail issue

nishat ahmad’s picture

nishat ahmad commented
StatusFileSize
new 3193918-9.patch391 bytes
djsagar’s picture

djsagar commented

Hi,

@ravi.shankar @Abhijith S and @Nishat Ahmad patch was failed by patch test with PHP 7.3.x-dev & MySQL 5.7.

Please re-work on that.

Thanks!

djsagar’s picture

djsagar commented
Status: Needs work » Needs review
StatusFileSize
new 3193918-7-patch.png41.98 KB
new 3193918-6-patch.png45.35 KB
new 3193918-5-patch.png46.49 KB

I checked all three patches, first two patch are same and code are same with diffrent order, all three patches applied successfully but all three patch are failed,

nishat ahmad’s picture

nishat ahmad commented
StatusFileSize
new 3193918-12.patch416 bytes
kumar ashutosh’s picture

kumar ashutosh commented
StatusFileSize
new bartik_status_design_issue_1_13.txt293 bytes
new bartik_status_design_issue_1_13.patch395 bytes
kumar ashutosh’s picture

kumar ashutosh commented
StatusFileSize
new bartik_status_design_issue_14.patch472 bytes
djsagar’s picture

djsagar commented
Status: Needs review » Needs work
djsagar’s picture

djsagar commented
Status: Needs work » Needs review
StatusFileSize
new 3193918-16.patch429 bytes

Changed the order for CSS,
The patch was small so didn't make interdiff file

Status: Needs review » Needs work

The last submitted patch, 16: 3193918-16.patch, failed testing. View results

djsagar’s picture

djsagar commented
Status: Needs work » Needs review
StatusFileSize
new 3193918-18.patch486 bytes

Just re-rolled the patch.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 3193918-19.patch486 bytes

Changed css order

djsagar’s picture

djsagar commented
Status: Needs review » Needs work

Need work as it's custom command failed.

djsagar’s picture

djsagar commented
Status: Needs work » Needs review
StatusFileSize
new 3193918-20.patch429 bytes

Re-rolled the patch for custom command issue.

Status: Needs review » Needs work

The last submitted patch, 21: 3193918-20.patch, failed testing. View results

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3193918-23.patch542 bytes
gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new rerolled-3193918-25.patch562 bytes
gauravvvv’s picture

gauravvvv commented
gauravvvv’s picture

gauravvvv commented
Status: Needs review » Needs work
abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new 3193918-28.patch648 bytes
new interdiff-3193918-25-28.txt644 bytes

Trying to resolve the failed test cases.

djsagar’s picture

djsagar commented
StatusFileSize
new 3193918-28.patch653 bytes

rolling up patch.

Status: Needs review » Needs work

The last submitted patch, 29: 3193918-28.patch, failed testing. View results

gauravvvv’s picture

gauravvvv commented
Related issues: +#2927806: Use PHPUnit 6 for testing when PHP version >= 7.2
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3193918-32.patch653 bytes
gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
bhumikavarshney’s picture

bhumikavarshney commented
StatusFileSize
new 3193918-34.patch2.86 KB
kumar ashutosh’s picture

kumar ashutosh commented
Status: Needs review » Needs work
ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Needs work » Needs review
StatusFileSize
new 3193918-36.patch2.77 KB
new interdiff_3193918_34-36.txt789 bytes

Fixed the custom command failure errors in #34, thanks!

Status: Needs review » Needs work

The last submitted patch, 36: 3193918-36.patch, failed testing. View results

vsujeetkumar’s picture

vsujeetkumar commented
Status: Needs work » Needs review
StatusFileSize
new 3193918-38.patch9.17 KB
new interdiff_36-38.txt6 KB

Fixing failing tests issues in #36, Thanks.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Project: Drupal core » Bartik
Version: 10.1.x-dev » 1.0.2
Component: Bartik theme » Look and Feel

Seems to be a bartik only issue. Since bartik has been removed in D10 moving to the contrib module

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 1.0.2 » 1.0.x-dev
Status: Needs review » Needs work

Please put the patch into an issue fork of Bartik and merge request.

tanushree gupta’s picture

tanushree gupta commented
Assigned: Unassigned » tanushree gupta
tanushree gupta’s picture

tanushree gupta commented

I attempted to reproduce the issue, but it seems that the Calendar module requires the Views Template module, which is no longer supported in Drupal 9. I also tried replicating the issue in Drupal 10, but I was unable to observe any design break in the status message.
If there are any steps or settings I may have missed, please let me know. Otherwise, if the issue isn't reproducible by others, we can consider closing it.
Thank you

tanushree gupta’s picture

tanushree gupta commented
Assigned: tanushree gupta » Unassigned
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -bartik theme