I usually work with Zymphonies theme for my website, but I decided to tryout the default thee for Drupal 8 and noticed a white framing around my block, which is a picture, which doesn't happen in Zymphonies theme.

This is explaining the same thing with picture evidence : http://suryanaru.epizy.com/drupal/node/4

I use php 5.4 , and it is on every OS I use the website in.

CommentFileSizeAuthor
#7 Screen Shot 2018-01-27 at 12.01.31.png1.02 MBjohn cook
#7 Screen Shot 2018-01-27 at 11.59.08.png744.26 KBjohn cook
#6 Bartik_theme-Frame_around_Block-2934834-6.patch806 bytesvipul tulse
asd.PNG13.38 KBSuryaNarukullapati

Comments

SuryaNarukullapati created an issue. See original summary.

cilefen’s picture

cilefen commented
Component: theme system » Bartik theme
vipul tulse’s picture

vipul tulse commented
Assigned: Unassigned » vipul tulse
vipul tulse’s picture

vipul tulse commented
Status: Active » Needs work
cilefen’s picture

cilefen commented
Status: Needs work » Active

There is not yet a patch.

vipul tulse’s picture

vipul tulse commented
Status: Active » Needs review
StatusFileSize
new Bartik_theme-Frame_around_Block-2934834-6.patch806 bytes

This very simple CSS style problem.
Made changes into sidebar.css under Drupal\core\themes\bartik\css\components

john cook’s picture

john cook commented
Status: Needs review » Needs work
Issue tags: +Needs subsystem maintainer review
StatusFileSize
new Screen Shot 2018-01-27 at 11.59.08.png744.26 KB
new Screen Shot 2018-01-27 at 12.01.31.png1.02 MB

I've had a look at this issue and I'm a little confused by it.

The patch changes the css for .sidebar .block but on the page you link to, you mention adding the block to the footer.

So when the patch is applied nothing happens to the footer blocks:
(Before and After)

When the blocks were moved to the sidebar, there was no real difference in the appearance (but the css had changed):
(Before and After)

I've added "Needs subsystem maintainer review" as it will need sign-off by them.

You may want to have a look at creating a sub-theme of Bartik instead of changing the core code.

Version: 8.4.4 » 8.4.x-dev

Core issues are now filed against the dev versions where changes will be made. Document the specific release you are using in your issue comment. More information about choosing a version.

Version: 8.4.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Branches prior to 8.8.x are not supported, and Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

pameeela’s picture

pameeela commented
Project: Drupal core » Bartik
Version: 9.5.x-dev » 1.0.2
Component: Bartik theme » Look and Feel
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: -Needs subsystem maintainer review +Bug Smash Initiative, +Needs issue summary update, +Needs steps to reproduce

The link in the IS doesn't work anymore. Needs steps to reproduce.

As the earlier patch only touches CSS in Bartik, I'm moving this to contrib.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 1.0.2 » 1.0.x-dev
Assigned: vipul tulse » Unassigned
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 1.0.x-dev » 1.1.x-dev
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

You may re-open this and provide steps to reproduce the problem.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.