Comment form select styling differs from other selects

I've just removed border-radius at this patch to make it absolutely 100% as on node create/edit pages. But i think we need more description about it, coz looks like on your first screen it is seven theme for administration theme, so i can't understand the phrase "1. Use Bartik theme to setup site."

On my screen there is bartik theme as default and as administration theme and it looks ok for now on my side after this little patch. But if you talk about bartik - default theme, and seven - administration theme => in this case i think we don't need any changes, coz selectboxes at administration theme doesn't have any styles. So styles are default, just related to browsers (everywhere it's different).

I'll resume. So:
1. I think we need more clear description of this task
2. Maybe more screens

Now how it looks at my FF (linux as well) after this patch

In my case the dropdown button in comment body has a border-radius but there there is no such thing in the article body.
So I think this should work.

@neerajpandey Thanks for picking this up. I tested your patch and it looks like the patch cannot be applied to drupal 8.2.x . Also I would advise you to apply the patch locally before posting it to the d.o , it saves a lot of time.. Or else you can use dreditor.

@neerajpandey Try this patch, i think it does what you wanted to do. I have added you as author while submitting the patch.

Here are the screenshots after applying the patch in comment 7. According to this issue both these select boxes should have the same styling and this patch actually solves the issue.

I tested, confirmed this bug.
Also, tested that the patch changes the radius of the comment form.

Change issue summary
Change the step one of how to create bug.

Unrelated random fail b/c #2828559: UpdatePathTestBase tests randomly failing. The patch failed because of this, there is no problem with the patch. I am setting the issue as fixed.

Again settings this to RTBC as the fails were unrelated.

So I think this needs more thought. Firstly I'm not sure I agree with the premise that the boxes should look the same. But anyway... even if so..

.comment-form input,
.comment-form .form-select {
  margin: 0;
  border-radius: 4px;
}

in bartik's form css is purposefully styling it like this.

Also this "issue" if it one can be caused by unticking the checkbox for "Use the administration theme when editing or creating content" on admin/appearance

In this patch i have removed the border radius from the select field instead of overriding the border radius for select field and tested it also by unticking the checkbox for "Use the administration theme when editing or creating content" on admin/appearance.

I've checked on my machine in FF and both selects looks same didn't found any difference. Adding screenshots for the same.

I tested the most recent patch on on a fresh instance and the issue appears to be still be active. The Text format select box is still displaying erroneously on the comment form doesn't match its counterpart on the Article creation form.

I am running the following specs:

Drupal Vers.: 8.4.0-dev
OS Vers.: macOS Sierra 10.12.4
Chrome Vers.: 58.0.3029
Firefox Vers.: 53.0 (64-bit)
Safari Vers.: Version 10.1 (12603.1.30.0.34)

I'm attaching screenshots from both Chrome and Firefox.

At this point I think the issue is still open and I will work on a new solution over the next few days.

Thank you for your time.

Hi sheavey:

I found this issue on the triage spreadsheet for Baltimore while I've been assigning issue credit. Thank you for helping out. It looks as though you got partway through a triage. I could give you credit if you complete and document all triage steps. Thank you!

Issue tested on window and mac machine. it is working fine. Here are the attached screenshots.

@sheavey I have tested issue on mac firefox browser but could not replicate. I am using 53.0.2. What is yours?

I am moving to RTBC as could not replicate this issue.
@sheavey if you still facing issue and mark this issue as need work status

Reading through the issue summary I don't understand how does the patch address the problem? Would moving the border radius to not apply to the select box restore the original styling of the element?

Per #25.

In the comment form, I have applied the style in <select> element as similar to admin seven theme. After this patch you can find the same style as per the attached screenshot.

Please review this patch and let me know your feedback.

@pawandubey : I have added the latest patch that you have provided. Tested on Firefox, chrome and other browsers.
Problem still exists when we change theme to 'Bartik' and create article content.
Text format select box for comment body still have different styling on Firefox.

Updating patch for drupal 9.2.x-dev.

Please review.

Thanks!

Applied patch #39 on 9.2.x and it works fine.The selectbox styling is now same in comment and content section after this patch.Adding screenshot below.

After patch(Firefox browser):

Comment section

Content section

RTBC +1

Hi @djsagar ,
Thanks #39 patch resolve the firefox issue.

Bartik doesn't seem to have any styles that would customize the design of the select element. For that reason, I think it's fine to see different select element designs on different browsers.

I was confused by the title/issue summary at first. I read it as if there was a difference in how the select is rendered across different browsers. However, the issue summary explains that it's actually on Firefox but across different instances of the select.

+++ b/core/themes/bartik/css/components/form.css
@@ -299,6 +299,7 @@ input.form-submit:focus {
 .filter-wrapper .form-select {
...
+  border-radius: 4px;

I think we should set the border-radius in a rule targeting .form-select so that it's applied globally on all selects.

There's another part of this that affects all browsers - the text box inputs are styled differently too - see the title and subject text input boxes in #40.

Not sure about the best way to resolve this issue.

Moving project to Bartik because its now a contrib module

Hi All,

Created MR request for better look, kindly review.

Thanks!

I tried to apply the MR and now everything looks fine, with and without the patch both look fine, and the issue cannot be reproduced. Please check once. Attaching the SS for the same.