Problem/Motivation

 ------ ----------------------------------------------------------------- 
  Line   src/Plugin/migrate/source/d7/BlockedIps.php                      
 ------ ----------------------------------------------------------------- 
  20     Class Drupal\ban\Plugin\migrate\source\d7\BlockedIps extends     
         deprecated class                                                 
         Drupal\migrate_drupal\Plugin\migrate\source\DrupalSqlBase:       
         in drupal:11.3.0 and is removed from drupal:12.0.0. There is no  
         replacement.                                                     
         🪪  class.extendsDeprecatedClass                                 
 ------ ----------------------------------------------------------------- 
 [ERROR] Found 1 error

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ban-3572710

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

garvitasakhrani’s picture

garvitasakhrani commented

I am working on it.

garvitasakhrani’s picture

garvitasakhrani commented
Assigned: Unassigned » garvitasakhrani
mstrelan’s picture

mstrelan commented

I think we just want to add a phpstan-ignore-next-line comment, with a todo to remove it when we only support Drupal 12 and up.

garvitasakhrani opened merge request !5

garvitasakhrani’s picture

garvitasakhrani commented
Assigned: garvitasakhrani » Unassigned
Status: Active » Needs review

Thanks for the suggestion. I’ve addressed this by adding a targeted PHPStan suppression for the deprecated class extension, along with a clear @todo explaining that it should be removed once the module only supports Drupal 12+. This keeps PHPStan passing without broadly ignoring errors and documents why the suppression is needed.
Please review and let me know if this approach looks good or if you’d prefer a different handling.

anybody made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.