Problem/Motivation

PHPStan currently runs at level 0

Steps to reproduce

Proposed resolution

  • Configure phpstan at level 8
  • Fix issues that don't break BC
  • Ignore missingType.iterableValue
  • Ignore one instance of new.static
  • Baseline remaining issues

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ban-3540366

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !3

mstrelan’s picture

mstrelan commented
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Nice @mstrelan thank for the fixes!

mstrelan’s picture

mstrelan commented

Holding off on merging until after the stable core release, and #3539672: Ensure that Ban does not get special core treatment.

  • mstrelan committed 1853f311 on 1.0.x 
    chore: #3540366 Implement phpstan level 8

By: mstrelan
By: anybody
mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Fixed

Follow up: #3572710: Drupal\ban\Plugin\migrate\source\d7\BlockedIps extends deprecated class

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.