I really like the Bamboo theme. One minor issue is the way months are displayed. They are in English abbreviated form. If you use Drupal's format_date function, the theme will certainly be a global success!!

Comments

Danny Englander’s picture

Danny Englander
(he/him)
CreditAttribution: Danny Englander commented
Assigned: Unassigned » Danny Englander
Status: Active » Postponed (maintainer needs more info)

Hi I might be interested in this but I need a specific example of where this is an issue with the theme. Right now I use the php date function so it should pick up whatever your language is for the month for example. I'm using the short "M" date format as a stylistic choice for the date (month) in a node.

I really would not want to change that otherwise. Feel free to submit a patch or some example code but it should be relevant to Bamboo, not simply some abstract code referring to the API or a link to the API.

drupalaar’s picture

drupalaar CreditAttribution: drupalaar commented

I changed the following line in the node.tpl.php to use the Bamboo theme in Dutch:

Original: echo date("M", $node->created);

My change: echo format_date($node->created, "custom", "M");

Danny Englander’s picture

Danny Englander
(he/him)
CreditAttribution: Danny Englander commented
Version: 7.x-1.0-beta3 » 7.x-1.x-dev
Component: User interface » Code
Priority: Minor » Normal
Status: Postponed (maintainer needs more info) » Needs review

Hi thanks for this. I've implemented this in 1.x dev and 2.x dev. Can you have a look to make sure. I've tested it and it looks good to me. Thanks.

http://drupalcode.org/project/bamboo.git/blobdiff/3fac6d24c9f963a14504ff...

Danny Englander’s picture

Danny Englander
(he/him)
CreditAttribution: Danny Englander commented

Actually, I refined it by taking the date logic out of node and created variables in template.php

http://drupalcode.org/project/bamboo.git/commit/7fa6fe0

Danny Englander’s picture

Danny Englander
(he/him)
CreditAttribution: Danny Englander commented

Actually, I refined it by taking the date logic out of node and created variables in template.php

http://drupalcode.org/project/bamboo.git/commit/7fa6fe0
http://drupalcode.org/project/bamboo.git/blobdiff/e6ed7c3e5946803f2f2bc9...

Danny Englander’s picture

Danny Englander
(he/him)
CreditAttribution: Danny Englander commented
Status: Needs review » Fixed
drupalaar’s picture

drupalaar CreditAttribution: drupalaar commented
Title: Use format_date function instead of standard PHP date function to localize date format » Excellents solution! [EOM]
Danny Englander’s picture

Danny Englander
(he/him)
CreditAttribution: Danny Englander commented
Title: Excellents solution! [EOM] » Use format_date function instead of standard PHP date function to localize date format

Please don't change the title, it's important for people to be able to scan through the issues to quickly see if this is one they are having. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.