Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi!
I made some improvements into this module I was needing for a project. I would like to share, so may be useful for anybody else.
- token integration, useful when composing mail to users and other uses
- rules integration, allows check current user's balance as a condition, and actions for balance adjustment (entry creation)
- realname integration, see #898632: RealName support
- ascending / descending sort, configurable, show balance as a bank account, last entry at bottom of list
- current user's balance hilight
- user edit tab for balance instead of menu link
- empty balance message when there are no entries in users balance tracker yet
May be tested by community before porting to stable version.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 1_rules_action.patch | 6.11 KB | Kiphaas7 |
| #8 | 2_tab.patch | 506 bytes | Kiphaas7 |
| #8 | 3_enhanced_form_and_realname.patch | 10.4 KB | Kiphaas7 |
| #8 | 4_admin_form.patch | 4.46 KB | Kiphaas7 |
| #8 | 5_post_cleanup.patch | 381 bytes | Kiphaas7 |
Comments
Comment #1
brianV CreditAttribution: brianV commentedWow - that's an awesome patch. Thanks for submitting this back!
I am probably going to review and add these features one at a time in different issues rather than accepting a single, monolithic patch. Given that I have very limited availability at this point, it would be incredibly helpful if someone were able to break the different components of this patch into different issues, so each can be pulled individually.
Comment #2
brianV CreditAttribution: brianV commentedI am reviewing portions of this patch one by one, and committing as necessary.
Token integration has been committed to dev.
http://drupal.org/cvs?commit=447242
http://drupal.org/cvs?commit=447244
Comment #3
Ciprian Oancia CreditAttribution: Ciprian Oancia commentedPatch fails on several lines
Comment #4
brianV CreditAttribution: brianV commentedParts of this patch are already integrated into core, so yes, the patch doesn't apply cleanly...
Comment #5
Ciprian Oancia CreditAttribution: Ciprian Oancia commentedI saw, i had to do it by hand :)
Comment #6
brianV CreditAttribution: brianV commentedCiprian:
Please let me know how the other portions of the patch test out. I don't have time to really test them right now, but I would like to roll some of these features in if I can.
If you really want to help, it would really be helpful for me to have the separate portions of this patch into their own issue, so each can be tested and applied individually instead of a single large ball of patch.
Comment #7
Ciprian Oancia CreditAttribution: Ciprian Oancia commentedHi :)
I wish i knew more than basic php & drupal 7 behaviours as for example with rules integration i still have bugs eq:
Unable to add this event as it does not provide all variables utilized by the reaction rule unlabeled.
I do attach the rules integration .inc file as its outputed by the applied patch.
And i do hope in some day someone would implement #1064648: Payements , right now im one of the users in need of such thing :)
Comment #8
Kiphaas7 CreditAttribution: Kiphaas7 commentedI took the effort to break up the initial patch in 5 somewhat smaller patches. They are cascading; in other words, one needs to apply first #1, then #2, etc...
Comment #9
ramy_asha CreditAttribution: ramy_asha commentedWill such a patch ever exist for Drupal 7.x? I've installed Balance Tracker on one of our test sites and it's only 80% of what I'm looking for, I need "Invite Commissions" to work but it relies on "CA" which is missing, and from what I've seen is obsolete and replaced by the "rules" module. How can I integrate Invite Commissions with rules? Or better yet is there any way to get Balance Tracker & Invite Commissions fully functional on Drupal 7.x? Thanks in advance,
Comment #10
sergeypavlenko CreditAttribution: sergeypavlenko commentedThank you very much for the patches, I will try soon to apply all patches for your version of the module 7.x-1.x-dev.
After fixing all the errors of the module, the module and complete the transition to Drupal 7, we'll port "Invite Commissions" on D7.
Commits:
2_tab.patch - faebe53
4_admin_form.patch - 599f387 ( Was not added to the patch - the parameter "balance_table_sort", because it does need to write custom functionality. Many lines of patch previously been in the module. )
5_post_cleanup.patch - ecf69e6
Comment #11
kevinquillen CreditAttribution: kevinquillen commentedIs this a patch for D7 or D6?
Comment #12
brianV CreditAttribution: brianV commentedpretty sure this patch was submitted against the D6 version. However, parts of it are already rolled into core.