Better handling of destination and redirects [#2902213]

There are number of incompatibilities with the ported Drupal 7 2.x version of the code which don't work so well with Drupal 8 redirects and the destination URL.

e.g. logging in with a url like user/login?destination=my_url is not respected

Comment	File	Size	Author
#3	better-handling-of-destination-and-redirects-2902213-3.patch	3.9 KB	thtas
#2	better-handling-of-destination-and-redirects-2902213-2.patch	4.26 KB	thtas

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

15 August 2017 at 07:03

thtas created an issue. See original summary.

Comment #2

thtas CreditAttribution: thtas commented 15 August 2017 at 07:04

Status:

Active

» Needs review

File	Size
better-handling-of-destination-and-redirects-2902213-2.patch	4.26 KB

Patch attached

Comment #3

thtas CreditAttribution: thtas commented 15 August 2017 at 07:06

File	Size
better-handling-of-destination-and-redirects-2902213-3.patch	3.9 KB

Removed unrelated code change

Comment #4

thtas CreditAttribution: thtas commented 15 August 2017 at 07:07

1 file was hidden/shown/deleted

File	Size
better-handling-of-destination-and-redirects-2902213-2.patch	4.26 KB

Comment #5

neclimdul

He/Him

CreditAttribution: neclimdul commented 21 October 2021 at 21:04

Status:

Needs review

» Fixed

I had to rewrite a _ton_ of this logic. I'm not sure all of this would have worked with a lot of the security features in place now but it should be fixed now.