Problem/Motivation

As part of looking to migrate site(s) to D8, it would be useful to have a situation where parts of the site are D6 and parts are D8. It would be ideal to be able to have the bakery SSO option available to allow this to be done as seamlessly as possible.

This means at least the “client” side of bakery would be useful in a D8 module.

Proposed resolution

I’m very happy to work on creating a D8 bakery, with help, but initially want to know who else is interested or has already made a start?

Remaining tasks

Build a D8 version of the bakery module that works against bakery masters running in D6 and D7 sites.

User interface changes

none

API changes

none

Data model changes

none.

CommentFileSizeAuthor
#21 2699683-21-d8port-continued.patch33.05 KBthtas
#17 2699683-17.patch1.88 KBandypost
#14 bakery-n2699683-12.patch157.65 KBDamienMcKenna
#12 bakery.zip43.05 KBunnikrishnan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rachel_norfolk created an issue. See original summary.

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
CreditAttribution: rachel_norfolk at Open Development Ltd commented
Issue summary: View changes
geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented

Created #2700717: [bakery] Bakery Single Sign-On System to track in the contrib tracker.

neilt17’s picture

neilt17 CreditAttribution: neilt17 commented

Just to say I am interested - and will be in a mixed D6/D8 situation!

kathyq’s picture

kathyq CreditAttribution: kathyq commented

+1

rodtatham’s picture

rodtatham CreditAttribution: rodtatham commented

+1

fuzzy76’s picture

fuzzy76 CreditAttribution: fuzzy76 commented

I guess the blocker here is finding a new maintainer (as the project page states the need for one). But TBH, I would suggesting getting off the island and look at the https://www.drupal.org/project/cas and https://www.drupal.org/project/cas_server projects.

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
CreditAttribution: rachel_norfolk at Open Development Ltd commented

Do note, though, that there is no 6.x release for CAS.

neilt17’s picture

neilt17 CreditAttribution: neilt17 commented

Er, yes there is /was - https://www.drupal.org/project/cas/releases?api_version%5B%5D=87

unnikrishnan’s picture

unnikrishnan CreditAttribution: unnikrishnan as a volunteer commented

Hi,

I have ported this module to Drupal 8, it's tested and working fine. How I can contribute it to Drupal.

Can I upload here? please advice.

Thanks,
Unnikrishnan B.

fuzzy76’s picture

fuzzy76 CreditAttribution: fuzzy76 commented

I think the best way would be to apply for co-maintainership and get commit rights, so you could commit it to a D8 branch directly. Could be that the current maintainers would like to see your code first, though.

unnikrishnan’s picture

unnikrishnan CreditAttribution: unnikrishnan as a volunteer commented
FileSize
bakery.zip43.05 KB

Thank you @fuzzy76!,

How do I apply for co-maintainership? May be I will attached the code here so people can review it.

Thanks,
Unnikrishnan B.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: A bakery for Drupal 8? » Port Bakery to Drupal 8
Category: Feature request » Task

Standardized the issue title.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Version: 7.x-4.x-dev » 7.x-2.x-dev
Status: Active » Needs review
FileSize
bakery-n2699683-12.patch157.65 KB

Here's unnikrishnan's file in patch format.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Needs review » Fixed

Thanks for getting this port started. I committed it as-is; I haven’t tested it. Followups are best in separate issues, marking this fixed.

Testing should be automated with something like https://github.com/drumm/Bakery-Chef. I wasn’t able to get that running since it tracks the current release of Chef and apparently a lot has changed. Starting from scratch with DrupalVM might be the way to go today.

We’ve been running #2659992: Make subsite registration and login optional on Drupal.org for quite awhile and should be ported. It is still missing some functionality, but works well. I’d go as far as removing subsite login completely on D8.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented

https://www.drupal.org/sandbox/msajko/2877610 is a good place to look for followup issues.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Fixed » Needs review
FileSize
2699683-17.patch1.88 KB

Contrib tracker #2700717: [bakery] Bakery Single Sign-On System points to this issue but module does not work (port incomplete)

Maybe keep the issue open to allow others to follow?
Patch to fix config usage

  • drumm committed 1f909ed on 8.x-2.x authored by andypost 
    Issue #2699683 by andypost: Fix config usage
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Needs review » Fixed

Looks okay, committed.

Separate issues are better:

  • I can assign credit more-easily. For the last commit, the patch is wholly yours, so I have to uncheck everyone else, and remember not to save the issue that way.
  • Credit is finalized and visible on user & organization pages when the issue is fixed.
  • Long issues with a bunch of patches are harder to follow.

In general, contrib tracker isn’t canonical. Maybe it should link to https://www.drupal.org/project/issues/bakery?text=&status=Open&prioritie... ?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

thtas’s picture

thtas CreditAttribution: thtas commented
FileSize
2699683-21-d8port-continued.patch33.05 KB

Sorry to post a mega-patch.. but there was just too many inter-connected issues for me to get my head around how to separate things in to different parts. I wasn't sure where else to post..

Anyway, this was everything required to get Bakery functional between two d8 sites (running 8.4) based on
8.x-dev commit 1f909ed87b5fe59049acd80aed6d3d9b4fd14dd6 and the attached patch.

In addition to this patch you will also need to install the phpseclib/mcrypt_compat library when running under php 5.6+ via composer

This patch includes these other patches in the queue

PHP 7 / AES support
Source: https://www.drupal.org/files/issues/php-7-aes-support-2817213-3.patch

YML parse error in services.yml
Source: https://www.drupal.org/files/issues/YML-parse-error-in-services-2901427-...

Undefined variable: form_id
Source: https://www.drupal.org/files/issues/undefined-variable-form_id-2902214-2...

Better handling of redirects
Source: https://www.drupal.org/files/issues/better-handling-of-destination-and-r...

Too few arguments to function bakery_user_presave
Source: https://www.drupal.org/files/issues/too-few-arguments-to-function-bakery...

Properly redirect when tasting chocolate chip cookie on boot
Source: https://www.drupal.org/files/issues/properly-redirect-when-tasting-choco...

Permissions on routes not properly ported from 7.x
Source: https://www.drupal.org/files/issues/permissions-2902436-2.patch

P.S.

This module seems to have stagnated a fair bit. If you're considering Bakery as a SSO solution for drupal 8, also take a look at the CAS https://www.drupal.org/project/cas which seems to be in much better shape.

Sponsored by GamePress
https://gamepress.gg/