Hi,

I've noticed several directives in the .info file that are not necessary. The files[] directive should only be used for files containing Classes or Interfaces.

CommentFileSizeAuthor
#1 bad_judgement-useless_info_files-2155385-1.patch383 bytesJulienD
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JulienD’s picture

JulienD CreditAttribution: JulienD commented
Status: Needs work » Needs review
FileSize
bad_judgement-useless_info_files-2155385-1.patch383 bytes

Here is a patch tested on the 7.x-1.x version of the module

jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree commented
Status: Needs review » Reviewed & tested by the community

Quite right.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented
Status: Reviewed & tested by the community » Needs work

I'm tempted to close this as "works as designed", because this is actually a really handy feature. How else are you to know which files are part of the module and which files you placed in the module folder yourself?

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at PreviousNext commented
Title: Remove useless files[] directive from .info files » Arbitrarily change the title of this issue and make legolasbo a maintainer

  • JohnAlbin committed 3fe3931 on 8.x-1.x 
    Issue #2155385 by JohnAlbin: Arbitrarily change the title of this issue...
JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at PreviousNext commented
Status: Needs work » Fixed

Thanks for all of your hard work! I know it sometimes takes a while to get things committed to Drupal core Bad Judgement, but it pays off in the long run, though I'm not sure how.

I'd especially like to point out JulienD's work who I did not credit in any commits. Oops.

/**
 * Implements hook_update_N() badly.
 *
 * @param $sandbox
 *   @TODO: Figure out what sandbox is for.
 */
function bad_judgement_update_8000000(&sandbox) {
  drupal_set_message(t('Make legolasbo a maintainer even though he did not ask for it.'));
}

  • JohnAlbin committed 0bf3d5c on 8.x-1.x 
    Issue #2155385 by Ryan Weal: Aggressive commit

This reverts commit...
  • JohnAlbin committed 4431754 on 8.x-1.x authored by Ryan Weal
    Issue #2155385 by Ryan Weal: Passive commit

This reverts commit...

  • JohnAlbin committed 792902d on 7.x-1.x 
    Issue #2155385 by JohnAlbin: Arbitrarily change the title of this issue...
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented
Status: Fixed » Needs work

I know @JohnAlbin purposely forgot to commit to the 9.x branch, but I think it is imperative to open a 5.x branch to commit this patch to as well.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

So I get a commit credit for what exactly?

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented

@Ryan Weal

For being awesome ofcourse!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Woohooo Internet points!!1!