Write tests to confirm that each of the filename backup options works as intended.

CommentFileSizeAuthor
#9 backup_migrate-n2945704-9.interdiff.txt3.32 KBDamienMcKenna
#9 backup_migrate-n2945704-9.patch12.26 KBDamienMcKenna
#7 backup_migrate-n2945704-7.interdiff.txt10.43 KBDamienMcKenna
#7 backup_migrate-n2945704-7.patch11.94 KBDamienMcKenna
#5 backup_migrate-n2945704-5.patch4.91 KBDamienMcKenna
#5 backup_migrate-n2945704-5.interdiff.txt1.99 KBDamienMcKenna
#3 backup_migrate-n2945704-3.patch4.11 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue tags: +#fldc18
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
backup_migrate-n2945704-3.patch4.11 KB

WIP.

Status: Needs review » Needs work

The last submitted patch, 3: backup_migrate-n2945704-3.patch, failed testing. View results

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
backup_migrate-n2945704-5.interdiff.txt1.99 KB
backup_migrate-n2945704-5.patch4.91 KB

Lets see if this fixes the test failure.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: Unassigned » DamienMcKenna
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
backup_migrate-n2945704-7.patch11.94 KB
backup_migrate-n2945704-7.interdiff.txt10.43 KB

Further WIP.

Status: Needs review » Needs work

The last submitted patch, 7: backup_migrate-n2945704-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
backup_migrate-n2945704-9.patch12.26 KB
backup_migrate-n2945704-9.interdiff.txt3.32 KB

This should now cover the three use cases, lets try to get the tests green.

  • DamienMcKenna committed 48373a3 on 7.x-3.x 
    Issue #2945704 by DamienMcKenna: Write tests for each backup filename...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Yahoo! Tests are green!

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2942331: Plan for Backup and Migrate 7.x-3.6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: DamienMcKenna » Unassigned