I have been applying the security patch provided today https://www.drupal.org/sa-contrib-2018-004. I am noticing that when applying the patch, one of the file's permissions are being changed:

 mode change 100644 => 100755 .../backup_migrate/includes/sources.archivesource.inc

Is this expected behaviour?

Many thanks

CommentFileSizeAuthor
#6 backup_migrate-n2939277-6.patch117 bytesDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

baronmunchowsen created an issue. See original summary.

baronmunchowsen’s picture

baronmunchowsen CreditAttribution: baronmunchowsen commented
Title: File mode change in Backup & Migrate 7.34 » File mode change in Backup & Migrate 7.3.4
baronmunchowsen’s picture

baronmunchowsen CreditAttribution: baronmunchowsen commented

Apologies - appears this file has had these permissions since 7.x-3.0. Not sure if it needs to have permissions as 755. Seems to work just fine set to 644.
Cheers

baronmunchowsen’s picture

baronmunchowsen CreditAttribution: baronmunchowsen commented
Title: File mode change in Backup & Migrate 7.3.4 » File mode change in Backup & Migrate 7.x-3.4
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Version: 7.x-3.4 » 7.x-3.x-dev
Status: Active » Postponed (maintainer needs more info)

Please test with the new 3.5 release and let us know if the problem persists. Thanks.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Postponed (maintainer needs more info) » Needs review
Parent issue: » #2942331: Plan for Backup and Migrate 7.x-3.6
FileSize
backup_migrate-n2939277-6.patch117 bytes

I looked through the codebase and confirmed the report. This fixes the file permission.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed. Thanks for the report, baronmunchowsen.

  • DamienMcKenna committed 62d0adc on 7.x-3.x 
    Issue #2939277 by DamienMcKenna, baronmunchowsen: File mode change on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Category: Support request » Task