Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
From sources.filesource.inc
:
function _restore_from_file_php($file, &$settings) {
// Older B&M Files format included a base 'files' directory.
if (file_exists($temp .'/files')) {
$temp = $temp . '/files';
}
I see this exists for historical compatibility, but it causes a problem if your files directory contains a directory called 'files', for example, /sites/default/files/files
. Instead of restoring from /sites/default/files
, BAM will restore from /sites/default/files/files
.
This resulted in a bit of confusion on my part until I figured it out. Perhaps it's time to sunset this compatibility layer?
Comment | File | Size | Author |
---|---|---|---|
#2 | backup_migrate-2753175.patch | 702 bytes | entendu |
Comments
Comment #2
entendu CreditAttribution: entendu for eBay Enterprise commentedPatch in case you agree.
Comment #3
couturier CreditAttribution: couturier as a volunteer commentedThis patch may need to be rewritten based on 7.x-3.2.
Comment #4
DamienMcKennaComment #6
BrankoC CreditAttribution: BrankoC as a volunteer commentedI was thinking of rerolling the patch against the most recent 7.x-3.x-dev version, but I ran into two problems:
1) I cannot reproduce the issue (I do not know how to), so I cannot test the patch.
2) There is a second occurrence of the offending code, namely in the method _restore_from_file_cli(). It is not clear to me if that should be included in the reroll. I assume not, because the code _restore_from_file_cli() is older than this issue.