Problem/Motivation

I have two scheduled tasks with two different local destinations each (one for databases and one for files), and both backups where ending up in the same destination.

Proposed resolution

After debugging for hours and hours and realised that this was because of stale data in the profile object. The schedule loads a profile, but then the profile is modified and loaded with data across the different functions, and once the next schedule is loaded, the schedule in turn load the profile and because the profile have all of the stale data from previous run the destinations are not reset.

Looking at the code I really think profile data should not be cached, caching it could potentially led to a lot of difficult to spot issues, like this one. I project wise search the use of this function and it's used very seldom. Removing the case will pose little to none performance hit.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hanoii created an issue. See original summary.

hanoii’s picture

Status: Active » Needs review
FileSize
1.99 KB

Patch comes with a bunch of trailing spaces removed as per Drupal coding standards.

couturier’s picture

Status: Needs review » Needs work

This may need to be rewritten based on the 7.x-3.2 release.

hanoii’s picture

Status: Needs work » Needs review
FileSize
610 bytes

Re-rolled for latest dev and without the whitespaces.

DamienMcKenna’s picture

Status: Needs review » Fixed
Parent issue: » #2912211: Plan for Backup and Migrate 7.x-3.4

Committed. Thanks.

  • DamienMcKenna committed 0954938 on 7.x-3.x authored by hanoii
    Issue #2742855 by hanoii: Caching profile objects led to unwanted...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.