I'm reviewing a site with an older version of backup_migrate.

#2017027: Incorrect use of l() in a translated string changed a call from l() to url().

This fixes a performance issue during menu_rebuild() with an empty theme registry cache.

menu_rebuild() triggers this code via backup_migrate_menu()

l() is called.

l() triggers a theme registry rebuild.

This can take several seconds on some sites.

During this time, the router isn't written, so other requests get held in a lock_wait().

This would be fine because it was fixed, except there's a new call to l().

Patch coming up.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

Status: Active » Needs review
FileSize
910 bytes
dasha_v’s picture

See new patch attached for the latest version of the module.

couturier’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Needs review » Needs work

This may or may not need to be rewritten based on the 7.x-3.2 release.

DamienMcKenna’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: menu_rebuild_issue-2338841-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

Priority: Major » Normal
Status: Needs work » Needs review
Parent issue: » #2942331: Plan for Backup and Migrate 7.x-3.6
FileSize
1.46 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 6: backup_migrate-n2338841-6.patch, failed testing. View results

DamienMcKenna’s picture

  • DamienMcKenna committed 83c64ed on 7.x-3.x authored by catch
    Issue #2338841 by catch, dasha_v, DamienMcKenna: Incorrect translated...
DamienMcKenna’s picture

Status: Needs review » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.