Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The error message started to appear when the hosting service upgraded to PHP 5.4 with the default strict error setting.
Normally come when you are going to change any backup & migrate profile or to changes in advance setting.
The attached patch gets rid of this annoying error message in the most simpleminded way.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | backup_migrate-file-permissions.patch | 71 bytes | izmeez |
| #14 | 2329655-14-backup_migrate-php-warning-only-pass-variables-by-reference.patch | 526 bytes | izmeez |
| #1 | bam-php-5.4-issue-2329655.patch | 538 bytes | rohit.wadhwa |
Comments
Comment #1
rohit.wadhwa CreditAttribution: rohit.wadhwa commentedComment #2
YesCT CreditAttribution: YesCT commentedusing the more common tag (so I can delete the less commonly used one)
Comment #3
couturier CreditAttribution: couturier as a volunteer commentedDrupal 6 core and Backup and Migrate 6.x are no longer supported. I am moving this to the 8.x branch in case it may still be an issue.
Comment #4
couturier CreditAttribution: couturier as a volunteer commentedI'm actually going to close this issue since Drupal 8 requires a much newer version of PHP, so I think this issue is outdated.
Comment #5
DamienMcKennaCommitted. Thanks.
Comment #6
joelpittetThe spacing formatting on the patch is a bit wonky and it's only the second argument that needs to be a variable before passed by reference. Mind if I add a quick fix patch?
Comment #7
DamienMcKennaSure.
Comment #8
joelpittetI just realized this is only for Drupal 6, the version confused me. I do have this change on a D6 site but I'm not concerned enough to write a patch.
Comment #10
izmeez CreditAttribution: izmeez commentedThe patch in comment #1 also applies to backup_migrate-6.x-2.x however, the patch includes tab characters.
Comment #11
couturier CreditAttribution: couturier as a volunteer commented@izmeez the Drupal 6 version of this module is no longer supported.
Comment #12
izmeez CreditAttribution: izmeez commentedJust thought with the D6LTS continuing to make efforts including php 7.2 compatibility it might be useful to some people if they find this thread and backup_migrate has been a staple for a long time. Thank you.
Comment #13
izmeez CreditAttribution: izmeez commentedIt's interesting that the usage statistics for backup_migrate-6.x-2.8 show for week starting December 8, 2018 there are 4,629 sites using it. See https://www.drupal.org/project/usage/2128473
Comment #14
izmeez CreditAttribution: izmeez commented@couturier I respect your comment in #11.
Nonetheless, attached is what may be a better patch for both backup_migrate-6.x-2.x and 6.x-3.x where the previous patch has been committed to dev. This patch follows up on the comment in #6 and is in fact exactly what is in backup_migrate-7.x-3.x
I also noticed that the LICENSE.txt file has the wrong permissions, it should be 644 not 755. I am adding a patch for that here in case anyone needs to update an older D6 site.
Thank you all for your efforts over the years. It is appreciated.
Comment #15
DamienMcKennaThanks for your continued work on this.
Please note, files should have the 644 permission, not 755.
Comment #16
izmeez CreditAttribution: izmeez commented@DamienMcKenna Thanks for your comment. Yes, files should be 644. In my initial writing of comment #14 I made a mistake which I later edited to correct the comment. The patch for file permissions itself is correct, the LICENSE.txt file default is 755 and needs to be changed to 644. I just added that as a quick fix patch while trying to resolve the main issue.
Comment #17
izmeez CreditAttribution: izmeez commentedThe D6LTS project includes backup_migrate 6.x-2.x therefore I have added the patch from comment #14 to #3022206: [backup_migrate] php warning only pass variables by reference and can leave this issue to lie in peace. The LICENSE.txt file is no longer a part of the project and references to it no longer apply.