We should not use t() in the php file as per the coding standard and we have to use $this->t().

CommentFileSizeAuthor
#2 2871025-2.patch4.87 KBPavan B S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
FileSize
2871025-2.patch4.87 KB

Applying the patch, please review.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Needs review » Closed (duplicate)
Parent issue: » #2871067: Convert module to short array syntax and replace t() functions with $this->t()

This issue and https://www.drupal.org/node/2871019 will create conflict while committing code. Merging this both issues.

Thank you.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Closed (duplicate) » Fixed

Maintainer committed both the issues separately. Changing status to fixed.

pankajsachdeva’s picture

pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commented

Hi @Pavan and @dhruvesh,

Thanks for contributing.

I had applied this patch successfully.

Thanks.

pankajsachdeva’s picture

pankajsachdeva CreditAttribution: pankajsachdeva as a volunteer and at ]init[ AG commented
Status: Fixed » Closed (fixed)