Gitlab CI reports PHP_CodeSniffer errors/warnings which should be fixed.

Issue fork backerymails-3477017

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sunil jolapara created an issue. See original summary.

sunil jolapara’s picture

sunil jolapara commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 3.0.1 » 3.0.x-dev
Status: Needs review » Needs work

The MR does not fix all the PHP_CodeSniffer errors/warnings.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Needs issue summary update

The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.

Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.

cleavinjosh’s picture

cleavinjosh commented
Assigned: » cleavinjosh

cleavinjosh opened merge request !5

cleavinjosh’s picture

cleavinjosh commented
Issue summary: View changes
Issue tags: -Needs issue summary update

cleavinjosh changed the visibility of the branch 3477017-phpcs-issues to hidden.

cleavinjosh’s picture

cleavinjosh commented

No more phpcs issues found.

cleavinjosh’s picture

cleavinjosh commented
Assigned: cleavinjosh » Unassigned
Status: Needs work » Needs review

Hi,

Please review MR!4. Thank you.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

The only file that should be changed is inc/hooks.php.

cleavinjosh’s picture

cleavinjosh commented
Assigned: Unassigned » cleavinjosh
cleavinjosh’s picture

cleavinjosh commented
Assigned: cleavinjosh » Unassigned
Status: Needs work » Needs review

Hi @avpaderno,

Please review, check, and advise on MR!4. Thank you.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes