Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Working on it.
Comment | File | Size | Author |
---|---|---|---|
#4 | update_8_x_1_x_with--2638332--4.patch | 30.31 KB | Dom. |
#2 | update_8_x_1_x_with-2638332-2.patch | 24.13 KB | sumitmadan |
Comments
Comment #2
sumitmadan CreditAttribution: sumitmadan at QED42 commentedUpdated code according to latest drupal.
Comment #3
echoz CreditAttribution: echoz commentedPatched this on Drupal 8.0.2, seems to work great, thanks! Note the .info.yml is unchanged.
For those testing this module, installing 8.x-1.0-beta1 without patching, would not show the config screen, or it's menu item.
Comment #4
Dom. CreditAttribution: Dom. commentedThis patch is great. It does have some little issues through.
- some listed below
- hook_permissions() does not exist anymore and should be *.permissions.yml file instead.
- Indentation should be spaces instead of tabs.
Here is a new patch attached listing that. It surely have some other points to be corrected too, I made this very quickly!
I would have call it back_to_top_admin maybe since this is about assets for admin page only.
Why incluing this here ? Is it because of back_to_top_js requiring it ? Then it has to be a dependency of the library in *.libraries.yml thus.
The whole file here is poorly indented
Comment #5
echoz CreditAttribution: echoz commented#4 patch applied cleanly and works fine. The coding standards fixes seem certainly an improvement, but further than that, I'm not qualified for code review.
Comment #6
dzinelabs CreditAttribution: dzinelabs commentedIs the #4 the only that needs to be applied? And what file needs to be patched?
Comment #7
Dom. CreditAttribution: Dom. commentedPatch #4 is the only one that needs appliance, on 8.x-1.x-dev branch.
You should let GIT handle this. See "Apply patch" at https://www.drupal.org/project/back_to_top/git-instructions
Comment #8
dzinelabs CreditAttribution: dzinelabs commented@Dom, I use netbeans for patching and unfamiliar with Git.
Comment #9
Reuben Unruh CreditAttribution: Reuben Unruh commented#4 is working. Thanks!
Comment #11
sumitmadan CreditAttribution: sumitmadan at QED42 commentedThanks to all for their contribution. :)