If you scroll up and down fast then you see that animation has queued and will take some time to end. I think animation should be forced to stop before new has started.

CommentFileSizeAuthor
#1 back_top_top-fade_animation_will_queue-2383655-1.patch561 byteshkirsman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hkirsman’s picture

hkirsman CreditAttribution: hkirsman commented
FileSize
back_top_top-fade_animation_will_queue-2383655-1.patch561 bytes

Submitting pathc.

Please add my name to git log if you decide to implement this.

hkirsman’s picture

hkirsman CreditAttribution: hkirsman commented

Or maby just FadeTo 0 should be stopped. Because if you scroll fast and it's a long page then fadeIn will pause until you stop.

Rudi Teschner’s picture

Rudi Teschner CreditAttribution: Rudi Teschner commented

Patch is working and the artifact of the button caused by the fading doesnt appear anymore.

l.antonova’s picture

l.antonova CreditAttribution: l.antonova commented

Good patch!

acke’s picture

acke CreditAttribution: acke at Happiness commented
Status: Active » Needs review

Thanks for the suggestion, here comes some feedback, better late than never as you say. I don't think the feeling in the animation gets good with the patch. But it's also not good that the animation flashes if you scroll up and down but a better aproach can be to just fade out on stop. Like this code:

      function backToTop() {
        if ($(window).scrollTop() > settings.back_to_top.back_to_top_button_trigger) {
          $('#backtotop').fadeIn();
        } else {
          $('#backtotop').stop(true).fadeOut();
        }
      }

  • acke committed 1c2fe5f on 7.x-1.x 
    Issue #2383655 by hkirsman,acke: Fade animation will queue
acke’s picture

acke CreditAttribution: acke at Happiness commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.