Closed (fixed)
Project:
Automatic Updates
Version:
3.0.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Dec 2023 at 15:15 UTC
Updated:
11 Jan 2024 at 17:29 UTC
Jump to comment: Most recent
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #6
tedbowComment #7
phenaproximaComment #8
tedbowLooks good. If tests pass🎉
Comment #9
tedbowComment #11
phenaproximaComment #13
phenaproximaWell, I tried as hard I could to get the functional tests passing, but for some reason they all can't access Drupal. I think probably the symlink created at
/var/www/htmlis pointing to the wrong place. It's hard to override, if not impossible; chances are, our best bet is to wholesale copy thephpunit-basejob from the template and modify it to our liking.Comment #16
tedbowComment #20
tedbowMarking this as fixed
We should do this next #3411110: Test Automatic Updates and Package Manager as part of Drupal core 11.x on GitLab CI which require module changes to make it compatible with 11.x core
and then #3411111: Automatic Updates Gitlab Conversion test issue which a core scratch issue to get the build tests passing on the core merge requests
Getting the core build test running here is lesser priority then that other 2. If we got the build test running here there is not telling if that would make the build tests passing on the core merge request whereas if we don't do #3411110: Test Automatic Updates and Package Manager as part of Drupal core 11.x on GitLab CI we can be guaranteed they would NOT pass on the core merge request.
Working on any changes we need to either to the module itself or to core's own .gitlabci.yml file in #3411111: Automatic Updates Gitlab Conversion test issue we will be the best way to make sure the build tests pass on the core version. As much as we have made or use of gitlab similar to core's it won't be exactly the same.
Hopefully when AutoUpdates is a Beta module in core we can create a new a 4.0.x branch what relies on the core module. Then we will only have to worry about the build tests in AutoUpdates Extensions and those tests can written to extend the base tests in core in which form they are in at that time.
Comment #21
tedbowI have added a "Core Merge request planning" section to the summary of #3319030: Drupal Core Roadmap for Package Manager and Update Manager to list the issues that need to addressed