Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

phenaproxima created an issue. See original summary.

tedbow made their first commit to this issue’s fork.

tedbow’s picture

Title: Run unit tests on GitLab CI » Run kernel tests on GitLab CI
phenaproxima’s picture

Status: Active » Needs review
tedbow’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. If tests pass🎉

tedbow’s picture

Title: Run kernel tests on GitLab CI » Run kernel tests on GitLab CI after module is converted to core version

  • phenaproxima committed 849277cb on 3.0.x authored by tedbow
    Issue #3409774 by phenaproxima, tedbow: Run kernel tests on GitLab CI...
phenaproxima’s picture

Title: Run kernel tests on GitLab CI after module is converted to core version » Run functional tests on GitLab CI
Status: Reviewed & tested by the community » Needs work

phenaproxima’s picture

Well, I tried as hard I could to get the functional tests passing, but for some reason they all can't access Drupal. I think probably the symlink created at /var/www/html is pointing to the wrong place. It's hard to override, if not impossible; chances are, our best bet is to wholesale copy the phpunit-base job from the template and modify it to our liking.

  • tedbow committed 91f16bad on 3.0.x authored by phenaproxima
    Issue #3409774 by phenaproxima, tedbow: Run functional tests on GitLab...

tedbow’s picture

Title: Run functional tests on GitLab CI » Run build tests on GitLab CI on converted module

  • tedbow committed 073e7a94 on 3.0.x
    Issue #3409774 by phenaproxima, tedbow: Run build tests on GitLab CI on...
tedbow’s picture

Title: Run build tests on GitLab CI on converted module » Run Unit, Kernel, Functional and JS tests on GitLab CI on converted module
Status: Needs work » Fixed

Marking this as fixed

We should do this next #3411110: Test Automatic Updates and Package Manager as part of Drupal core 11.x on GitLab CI which require module changes to make it compatible with 11.x core
and then #3411111: Automatic Updates Gitlab Conversion test issue which a core scratch issue to get the build tests passing on the core merge requests

Getting the core build test running here is lesser priority then that other 2. If we got the build test running here there is not telling if that would make the build tests passing on the core merge request whereas if we don't do #3411110: Test Automatic Updates and Package Manager as part of Drupal core 11.x on GitLab CI we can be guaranteed they would NOT pass on the core merge request.

Working on any changes we need to either to the module itself or to core's own .gitlabci.yml file in #3411111: Automatic Updates Gitlab Conversion test issue we will be the best way to make sure the build tests pass on the core version. As much as we have made or use of gitlab similar to core's it won't be exactly the same.

Hopefully when AutoUpdates is a Beta module in core we can create a new a 4.0.x branch what relies on the core module. Then we will only have to worry about the build tests in AutoUpdates Extensions and those tests can written to extend the base tests in core in which form they are in at that time.

tedbow’s picture

I have added a "Core Merge request planning" section to the summary of #3319030: Drupal Core Roadmap for Package Manager and Update Manager to list the issues that need to addressed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.