I tested the beta1 version to update from 10.0.5 to 10.0.11.
this worked well. It detected that the User module had a DB update and routed me to update.php after the update was completed.
but after I ran the DB UPdates I went to the status report. It still show an error in the Readiness Check saying an DB update needed to be run with a link update.php. but clicking the link confirm there was no updates. Running the readiness check manually fixed it
Figure out why this is happening
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
tedbowFigured out why this is happening
\Drupal\automatic_updates\Form\UpdateReady::submitFormwill setup the batch to run post applyThe
\Drupal\automatic_updates\Validation\StatusChecker::clearStoredResultsget triggereds on post applybut
\Drupal\automatic_updates\Controller\UpdateController::onFinishruns the checkers before redirecting to update.php. So the status checks are run after the code is updated but before the DB updates are run. This meansPendingUpdatesValidatoris going to flag an error that will stored in cache just before the DB updates are run.So we need to someone clear the results after update.php is run
Comment #4
tedbowPushed up an idea. will see if any other tests break but it will needs tests of its own
Comment #5
tedbowLooks like we had explicit test coverage that PendingUpdatesValidator had an error and status checks were not run if you had to go to update.php
So looks like I just had to update the existing test expectations.
Comment #6
phenaproximaI don't think I have anything to complain about here. It's a nice fix.
Comment #8
tedbow@phenaproxima thanks for the review