Closed (fixed)
Project:
Automatic Updates
Version:
3.0.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
15 May 2023 at 16:27 UTC
Updated:
6 Sep 2023 at 20:39 UTC
Jump to comment: Most recent
Follow-up #3351895: Add Drush command to allow running cron updates via console and by a separate user, for defense-in-depth. Pretty much the same reasoning as #3351895 but we can't rely on Drush in Drupal core
Add a symfony console command that allows running updates. Remove the existing drush command since this was only in Alpha version and all references to Drush in the codebase
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
tedbowNot adding sprint tag right now as I figure out what else needs to be done for #3284443: Enable unattended updates
Comment #3
tedbowcore/scripts/db-tools.php might be a example of how to write a php file to invoke a console command.
\Drupal\Core\Command\ServerCommand::boot might be a example of how to create a command the boots
Comment #4
tedbowComment #5
wim leers#3++
Why is this not ? Is this not blocking a commit to Drupal core? (Drupal core does not provide Drush commands, and we won't be allowed to change that.)
Comment #8
tedbowComment #9
tedbowComment #10
tedbowComment #11
tedbowThere is on todo left pointing to this issue in
\Drupal\Tests\automatic_updates\Kernel\TestCronUpdateStage::runTerminalUpdateCommand()We don't actually need to run the command in kernel tests as of now so we could just remove the todo. We if we could run the command in kernel tests then we could probably convert
StatusCheckFailureEmailTestback to kernel test which was before #3357969: For web server dependent unattended updates run the entire life cycle in a separate process that will not be affected by hosting time limits but that is not super important as it does work as a functional.Either way we need to remove the todo
Comment #12
phenaproximaRe #11, I have removed the todo. I don't think we can run the terminal command in kernel tests, because it needs to boot into a real(-ish) Drupal site with a real file system, and kernel tests don't have either of those things. (It's true that our kernel tests use the real file system for certain things, but those stub sites are not bootable.)
Comment #13
phenaproximaComment #14
phenaproximaComment #15
tedbowLooks good!
RTBC, hoping both branches pass
Comment #17
phenaproxima