Problem/Motivation

follow-up to #3326934: Tests are failing for php 7.4.

Proposed resolution

scripts/src/Converter.php could remove the `@requires PHP >= 8.0` annotations

Issue fork automatic_updates-3327229

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Related issues: +#3326934: Tests are failing for php 7.4
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Title: Remove skip tests in core Merge Request convert » Remove skip tests in core Merge Request converter
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Version: 8.x-2.x-dev » 3.0.x-dev
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove skip tests in core Merge Request converter » Remove `@requires PHP >= 8.0` annotation from all tests
Category: Bug report » Task
Priority: Normal » Minor

Since #3321474: Adopt PHP 8.1-only capabilities such as constructor property promotion + drop BC layers, no tests need to be removed anymore, since PHP 8.1 is already the minimum requirement anyway!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » yash.rode

yash.rode made their first commit to this issue’s fork.

yash.rode opened merge request !719

yash.rode’s picture

yash.rode commented
Assigned: yash.rode » wim leers
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +sprint

🚢

phenaproxima made their first commit to this issue’s fork.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Looks great. I confirmed that @requires is no longer in the code base. Shipped!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.