Right now, this is the phrasing that Updater uses when re-throwing an ApplyFailedException:
The update operation failed to apply. The update may have been partially applied. It is recommended that the site be restored from a code backup.
I think there are problems here:
"The update may have been partially applied." This is a technical detail that is probably meaningless to end users; what we should be saying here is "You site may be unavailable or not working properly."
"It is recommended that the site be restored from a code backup." Not strong enough! I'd suggest "It is strongly recommended to restore your site's code and database from a backup."
Change the wording of the exception.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
phenaproximaComment #4
tedbowComment #5
balsamaThese two sentences next to each other seem almost contradictory:
Can we combine into: "The update operation failed to apply completely."
Revealing technical details doesn't seem problematic. But if this exception is tied to copying the runtime files into place, why not say that explicitly?
"The update operation failed to apply completely. All the files necessary to run your Drupal application may not be present."
I don't have strong opinions about the inclusion of "strongly", but to combine @phenaproxima's suggestions, the complete message:
Comment #6
tedbow#5 looks good to me!
Thanks @balsama
Comment #7
phenaproximaI feel like this sentence could be stronger. I think we can't make it more starkly clear than "Your site may be unavailable or not working properly." Considering the alarming nature of this exception, I think we should go for the more alarming wording.
That said, #5 is a big improvement already, so I won't block it.
Comment #8
phenaproximaAfter talking it over with @tedbow in Zoom, I'd suggest:
Comment #9
phenaproximaComment #10
phenaproximaComment #11
tedbowComment #13
phenaproximaThanks, all, for the productive wordsmithing. I'm glad we found something we could all agree on. Merged into 8.x-2.x!
Comment #15
tedbow