UpdaterForm throws an exception if you try to update to the next minor beta

ok this is because

$first_release_version = $next_minor_version->getMajorVersion() . '.' . $next_minor_version->getMinorVersion() . '.0';

will get 9.5.0 but that is not released yet. so we can't make this link if the first stable release of the major is not out

At the very least we should catch the exception.

Looking at this, I think this shouldn't be an exception. We should just flag a warning message if release notes are not available.

Added a proposed resolution.

Re-titling for clarity.

Looking at this, I think this shouldn't be an exception. We should just flag a warning message if release notes are not available.

In this case I don't think we need a warning.

basically originally in #3291730: When displaying updates in the next minor, show a link to the relevant major.minor.0 release notes the idea was if you are updating from 9.4.6 to 9.5.6(or anything above 9.5.0) you should also see a link to 9.5.0 because this is where the big changes between 9.4.x and 9.5.x will be documented.

but if you latest in 9.5.x is only a pre-release, 9.5.0-beta1 for example, then 9.5.0 will not exist so there is no need to show any other release notes beside 9.5.0-beta1. so in that case we don't need to have link in the table caption. so \Drupal\automatic_updates\Form\UpdaterForm::createReleaseTable() will not need a link in the $caption argument

Discussing this with @tedbow on Zoom, this is what we agreed on as the right solution here.

First of all, this issue is only about what to do when generating the table caption that is shown above the table where you see the update to the next minor. No other part of the form should be affected.

Here's the logic we think we should do:

If the target version of core is greater than -- NOT greater or equal -- the .0 release of the next minor, the caption should link to the release notes for the MAJOR.MINOR.0 release. If we cannot get those release notes (i.e., the release is unavailable), that's an error condition and should raise a LogicException.

In any other situation, don't link to the release notes in the caption. They are already linked in the table itself.

In pseudocode (this is here merely as guidance, it won't work if used directly):

if ($next_minor_release) {
  $next_minor_version = ExtensionVersion::createFromVersionString($next_minor_release->getVersion());
  $first_release_version = $next_minor_version->getMajorVersion() . '.' . $next_minor_version->getMinorVersion() . '.0';

  $caption = $this->t('Latest version of Drupal @major.@minor (next minor)', [...]);
  if (Composer\Semver\Comparator::greaterThan($next_minor_release->getVersion(), $first_release_version)) {
    if (empty($available_updates['drupal']['releases'][$first_release_version])) {
      throw new \LogicException();
    }
    $next_minor_first_release = ProjectRelease::createFromArray($available_updates['drupal']['releases'][$first_release_version]);
    $caption = $this->t('@caption (<a href=":url">Release notes</a>):', ['@caption' => $caption, ':url' => $next_minor_first_release->getReleaseUrl()]);
  }

  $form['next_minor'] = $this->createReleaseTable($next_minor_release, $installed_minor_release ? $this->t('Minor update') : $release_status, $caption, ...);
}

I can verify this issue. I got the white screen with "The website encountered an unexpected error. Please try again later" and the below message in the logs and ended up here.

LogicException: Release information for Drupal 9.5.0 is not available. in Drupal\automatic_updates\Form\UpdaterForm->buildForm() (line 264 of /var/www/digikojo.com/public_html/drupal_auto4/web/modules/contrib/automatic_updates/src/Form/UpdaterForm.php).

I manually patched my version of Automatic Updates with the code from here https://git.drupalcode.org/issue/automatic_updates-3310666/-/compare/8.x...

This worked, I was able to update from 9.4.5 to 9.4.7 (with the option to update to 9.5.0-beta2)

@rahul_ asked me to take this on.

I think we've got our bases covered for tests. Just a few small requests and then I'm happy.

I'm happy with this; assigning to @tedbow for final review and commit.

One thing I wonder: do we maybe want test coverage to confirm that the exception is thrown if, for some reason, we can't get release info for the x.y.0 release? I don't think we had any such coverage before, so I don't know if that should block commit, but thought I'd raise the question.

ok the reason the tests are currently failing is because is in \Drupal\package_manager\ProjectInfo::getInstallableReleases if the update module considers the project "current" we don't return any releases. But the update module will consider the project "current" if there the only newer releases in the current major are pre-releases.

we need to solve this problem first #3310696: if only newer releases are pre-releases Updating from one minor to latest version Drupal version, module does not show any other updates

crediting @siramsay for testing the issue

I think this is good. Will merge if green

Thanks everyone!