Problem/Motivation
Right now, there's a discrepancy in the way Package Manager resolves the system temporary directory (where the staging area is created). In \Drupal\package_manager\ProcessFactory::getComposerHomePath(), we use FileSystemInterface::getTempDirectory(), and in \Drupal\package_manager\Stage::getStagingRoot() we use FileSystem::getOsTemporaryDirectory().
The difference is that the former will first try to use the file_temp_path setting before falling back to the system temporary directory, and the latter doesn't. This needs to be made consistent.
Steps to reproduce
Proposed resolution
Always use FileSystemInterface::getTempDirectory() to get the temporary file path.
Remaining tasks
Do it, and write tests.
Issue fork automatic_updates-3278411
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
phenaproximaAssigning to @tedbow for review.
Comment #4
phenaproximaAssigning to @tedbow for review.
Comment #5
tedbowLooks good!
Comment #6
tedbowComment #7
phenaproximaI suspect this was accidentally kicked from RTBC to NR, so restoring RTBC.
Comment #9
phenaproximaMerged into 8.x-2.x.
Comment #12
tedbow