Problem/Motivation

in #3275886: Pick correct next possible update to avoid inaccurate warnings about being unable to update on cron we determine that when we pick the correctly that there is not valid update version to check readiness check, this could because you are latest in current minor, we don't need to any validation so we don't validate your current version.

Steps to reproduce

Proposed resolution

Make that validate the installed version. For instance you can never update *from* a dev version

We also need remove the validation of the installed/from version from UpdateVersionValidator and probably UpdateVersionValidator

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork automatic_updates-3276031

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue tags: +stable blocker

phenaproxima made their first commit to this issue’s fork.

phenaproxima opened merge request !287

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes

kunal.sachdev made their first commit to this issue’s fork.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs work
Issue tags: +Needs tests

Looks good so far. We will need to update test coverage.

kunal.sachdev’s picture

kunal.sachdev commented
Status: Needs work » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Needs work

looks good. needs work for a couple minor issues

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review

Addressed your feedback, @tedbow.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: -Needs tests

Added a dedicated kernel test.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » tedbow

Assigning to @tedbow for review.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Reviewed & tested by the community

RTBC unless you want to fix my "super nit"

  • phenaproxima committed 2334a1d on 8.x-2.x 
    Issue #3276031 by phenaproxima, kunal.sachdev: Create installed version...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Merged into 8.x-2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.