Problem/Motivation

Currently sites are only put into maintenance mode when the database updates are being run.

But in all of the ways we document updating Drupal we always recommend updating putting your site maintenance mode when you start the update process. https://www.drupal.org/docs/updating-drupal

There could be unexpected behavior when the site is accessed while the files are being copied over or in the future when they are updated via composer.

Proposed resolution

Remove the DatabaseUpdateHandler plugins MaintenanceModeActivate and MaintenanceModeDisactivate and instead always put the site into maintenance mode when updating regardless of whether database updates are needed or not.

We could still make it possible custom code opt out of this behavior by extending \Drupal\automatic_updates\Services\InPlaceUpdate

Remaining tasks

Determine if it is common practice and needed functionality to not put a site into maintenance when updating.

User interface changes

API changes

Removal of the DatabaseUpdateHandler plugins MaintenanceModeActivate and MaintenanceModeDisactivate. This would need to be done in the 8.x-2.x branch

Comments

tedbow created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented

Yes, addition of this make a lot of sense.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
Status: Active » Closed (outdated)

we are doing this now, but we don't take you out of maintenance mode. I will create an issue for that