Hello,

Just wanted to get started with knowing and contributing to Automatic Updates initiative. As a first step, I wanted to start with some small steps. I found that the action links present in the configuration page to be less appealing. Thus IMO, it would be better if we can show these links as buttons. This way it would be more accessible. Although this is an early phase yet to commit the configuration page. Thought this would be a good addition.

Thoughts? Thank you.

CommentFileSizeAuthor
#9 Screenshot from 2020-02-03 15-12-34.png111.6 KBheddn
#4 Screenshot 2020-01-23 at 4.09.00 PM.png336.42 KBJayKandari
#2 3108238-2.patch1.56 KBJayKandari
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JayKandari created an issue. See original summary.

JayKandari’s picture

JayKandari
Primary language Hindi
CreditAttribution: JayKandari as a volunteer and at QED42 commented
Assigned: JayKandari » Unassigned
Status: Active » Needs review
FileSize
3108238-2.patch1.56 KB

Added a simple "button" classes to the action links in the configuration page.

ressa’s picture

ressa CreditAttribution: ressa at Ardea commented

Thanks for improving the UI @JayKandari. Could you attach a screendump of it as well?

JayKandari’s picture

JayKandari
Primary language Hindi
CreditAttribution: JayKandari as a volunteer and at QED42 commented
FileSize
Screenshot 2020-01-23 at 4.09.00 PM.png336.42 KB

Sure.
The config form would look something like this after applying this patch.

Thank you.

ressa’s picture

ressa CreditAttribution: ressa at Ardea commented
Status: Needs review » Reviewed & tested by the community

Thanks for uploading the image @JayKandari. The patch works fine, and you're right that it makes the links look more actionable when presented as buttons.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Needs review

I'm not sure that this follows the typical style for in-line links in strings of text. If we want buttons, then we should move them down to the bottom of the page with all the other action buttons. But manually updating isn't something I want to highlite. Rather configuring cron is more what I want to encourage.

JayKandari’s picture

JayKandari
Primary language Hindi
CreditAttribution: JayKandari as a volunteer and at QED42 commented

Thanks, @heddn, @ressa.

Yup, something like the "clear cache" or "Run Cron" buttons provided by the core in a details container, I was thinking initially. But changing that much at this time would be unnecessary IMO. Thus sticking with changing the links to show as buttons. And the "manually update now" resides inside the already closed "experimental" details section. So, the manual update button won't show on the first look.

Keeping status as-is for more comments.

Thanks!!

JayKandari’s picture

JayKandari
Primary language Hindi
CreditAttribution: JayKandari as a volunteer and at QED42 for Drupal India Association commented
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Issue summary: View changes
FileSize
Screenshot from 2020-02-03 15-12-34.png111.6 KB

Since these links are inline, I still tend to side with the general trend I see on the status report page:

Here, you'll note that the page has an button to run cron, but it is styled out and spaced as an action. Lower down on the same page, there are links for Drupal core update status that are just inline. Based on the screenshots added here in #4, I'm inclined to mark as Won't fix. Because we have inline links. Unless we want to style things out more completely like the Run cron button. In which case, this is an instance of Needs Work to reword things and style more completely.