Sometimes when I log in I end up at mysite.com/autologout_ajax_get_time_left

and it is just a white page that says:

{"time":-1369372507000}

I'll try to get more info when I have a spare minute.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rooby’s picture

Then when I refreshed I was logged in and got this error:

Notice: Undefined index: autologout_last in autologout_ahah_get_remaining_time() (line 324 of /var/www/mysite/sites/all/modules/contrib/autologout/autologout.module).

rooby’s picture

Status: Active » Needs review
FileSize
536 bytes
johnennew’s picture

Status: Needs review » Active

Hi Rooby - this looks like a sensible patch.

Does it fix both of your issues? There is the notice and redirecting to autologout_ajax_get_time_left. I can't see how the code would cause you to redirect after log in to autologout_ajax_get_time_left and this patch does not look like it addresses this directly.

johnennew’s picture

Hi rooby, I've altered the patch in #2. I think setting it as you have done would leave the time remaining as 0 if the autlogout_last was not set which means you would be logged out? If autlogout_last is not set, I think the time_remaining should be the maximum timeout for the user. I've cleaned up the code a little to demonstrate what is going on.

Can you check if this patch is good?

johnennew’s picture

Status: Active » Needs review

Setting to needs review

rooby’s picture

Status: Needs review » Reviewed & tested by the community

Oops, I was in the middle of 2 other things so I wasn't paying enough attention.

Thanks for catching that, your patch looks good to me.

johnennew’s picture

Version: 7.x-4.x-dev » 6.x-4.x-dev

patch committed, switching to 6.x-4.x for the back port

johnennew’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
650 bytes

6.x-4.x Patch attached.

johnennew’s picture

Status: Needs review » Fixed

tests passed, applied patch.

johnennew’s picture

I've seen the white screen fault - the redirect URL is changed by system ajax callbacks. I've been working on the javascript as part of #2005776: Add support for JS Timer block in 4.x branches, latest patch does fix this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 9838eae on 7.x-4.x, 8.x-1.x authored by rooby, committed by ceng:
    Issue #2002548 by rooby and ceng: fixed white screen after login