'Allow user to choose' functionality doesn't work

I have the same problem with drupal 7

It doesn't come from the drupal api modifications, the source files of the module don't show any form alteration, only presave override. I think cyberswat decided to remove it until the port of this function is complete.

I managed to implement almost all the functionnalities the menu "Allow User to Choose" proposes.

--> The 2 patches change the .module and the .admin.inc files (the .admin.inc file had few wrong namings in the "Allow user to choose" form, and i slightly changed the form to match the registration functions requisites. see below)

---> If you are using Profile 2, you can configure the fields to specific roles by editing the permissions. This patch uses the "Edit own [profile name] profile" to automatically show/hide the corresponding fields in the registration forms, according to the role(s) the user chose. If you want a profile2 field to be shown in the registration form, check "show during registration" in the field settings, then enable the permission "edit own [profile name] field" to the roles you want. Then on the registration form, if the user select one or more roles that have this permission, the fieldset will appear.

--> I used the #states functionnality to achieve this, and i needed to patch the states.js with #735528: FAPI #states: Fix conditionals to allow OR and XOR constructions to allow multiple roles fields to be correctly displayed. I strongly recommend you to apply this patch if you want mine to work correctly.

--> If you play with the "single / multiple role" option and the "user selection type", you will notice that selection box is forced to checkboxes when multiple roles is chosen. That's because i couldn't get the #states conditions to recognize multiple values on a select input.

--> You can "lock" a specific role by passing the role name as argument in the URL. For exemple, if i go to "user/register/my role", and "my role" is enabled in the AAR settings, the registration form will grey out the role list and autoselect "my role" in it. That way you can create direct links to register one or other role easily.

--> I'm quite new in Drupal module development and i don't know if my patch has been cooked the right way. I used TortoiseMerge to do it and it seems that the patch basically rewrite the whole file...well it works anyway.

Feel free to comment and ask questions.

Ben

Patch works! Problem solved. Thank's Ben.

Sorry,
i made this patches with tortoise svn with the function "create unified diff file" of the TortoiseMergeGUI, apparently it doesn't work so well...

These ones are made with CygWin diff program with -u parameters, if someone has a better way to do it i'd be happy to hear it !

no worries ... I appreciate the help. Let's get the testing bot to pick these up and see how they do. When you submit a patch just set the status to 'needs review' and that serves as the trigger for the bot to come get them. Also, if you could consolidate the patches into a single patch vs multiple files I think your more likely to have them pass the testing bot.

@proffy I'm a newb when it comes to anything windows but let's try this and see how it goes. I'm going to make a few assumptions based on the way I work and what I think windows is doing for paths. Here's a good walkthrough of setting up cygwin for windows http://www.lullabot.com/videos/install-cygwin-windows-xp ... Once everything is working and you've made sure that your using unix settings (as outlined in the video) I think you'll do something like this:

cvs -z6 checkout -d autoassignrole-HEAD contributions/modules/autoassignrole/
--- Make all of your changes --
cd autoassignrole-HEAD
cvs diff -up > ~/autoassignrole-983612.patch

This should give you a single patch file that should work with the testbot.

Thanks for these tips and for the mail too, i'm getting better at this !
I configured my editing soft to use Unix line ending and 2 white spaces as indents, I think that's why the previous patch contained the whole files replacement, each line had a difference...
Anyway, good as new and ready to be tested, the patch !

I also added an option to show/hide the role field when role passed by url. In some cases, you want to provide direct links to specific-role registration without seeing the user to see others roles greyed out.

#11: autoassignrole-983612.patch queued for re-testing.

Okay, so the patch is in a good format now, but i don't really understand why the test takes a form field options change as a fail... indeed i changed the form options (checkboxes to radios, and removed 1 option), but why does it test the patch on a previous configuration ?

Ok, i guess i should have changed the test file too. Seems logical.
I got simpletest to work and it passed ! but it's taking a reaaaally long time just to test the AAR User Settings part... (22 mins).

Always forget to set to "needs review"...

Sweet ... As a general rule let's keep the tickets in the needs review status until we can paste a link to the commit message. Once the commit happens we'll move it to fixed so that it stays visible in the queues. I'll review this today.

As far as the time it takes to test don't worry about it ;) Testing is an intensive process and that's why we built the automated testing framework to help. We've spent a couple years tweaking and applying performance improvements to make it as fast as possible ... unfortunately most normal people won't have these on their environments.

Ok, thanks !
I actually found a problem in my patch, didn't realized that #disabled = TRUE makes the value of the field not pass to submit handlers...

So I added a settings to hide or show the field if role is passed in url, and used #attributes = style:display:none to hide it.

I also added a setting to choose which roles will need aministrator approval and which won't. As said in the description field, to use this option, administration approval must be disabled (registration set to "Visitors").

Finally, i digged into the user module and found a solution to fully use the default registration process. That way, it doesn't interfere with modules like rules, or others. The role & admin approval settings are set as it was the drupal core settings.

One issue is with modules like LoginToboggan which use the form_alter too, and put their user_register_submit handler before the others. For this cases, you might want to set the system module weight to you convenience, accordingly to your setup, or use a module like Util (when it'll be ported to D7). Just remember that this patch makes the module alter the form values before they are saved in the user, so if another module saves the user before (like LoginToboggan), it won't work.

Last thing is i just modified the Allow User To Choose part, and the initial part (Auto role assignment) was untouched (still uses _presave to store roles).

subscribing

Hello proffy, (or anyone who has successfully patched the files) How about posting your patched files (not just the patch) somewhere so others can access it. (if you mail it/them to me, I will gladly post)

I appreciate your efforts but you have only given us ½ the solution. The sad truth is that absent loadable (patched) files, there are hundreds, maybe a thousand, who knows, of us who are trying to develop a Drupal 7 site but are blocked because we cannot get past this problem.

Applying a patch may be a 30 second task for you and probably seems like a trivial matter, but trust me it is not. Remember not all of us have access to the necessary technology (e.g., a Tortiose CVS + server) or the expertise to actually apply the patch. Many of us have no platform upon which we can build a CVS server (e.g., due to security restrictions inside companies for example). In that case, we have no way to patch a file. Even if we can build a server, hours will be wasted researching and building, when folks like you could provide the solution to everyone in just a few seconds.

It would be most helpful and considerate, and it would go a long way to moving the Drupal 7 platform forward, if you would share your successful patched files with those who need it, but can't get there from here.
Thanks, Tim

Hi,
actually before doing this patch i had no idea on how to make it and how to apply it... i had to spend a few times indeed to understand how this system works but i think this is a really necessary system to manage fast issue resolution.

Secondly, it's really not a big deal to setup a checkout, you have to install cygwin with cvs (cvs & patchutils) and git (because drupal is moving to git).
Next you just have to open a command prompt and type
" cvs -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -d autoassignrole -r DRUPAL 7--1 contributions/modules/autoassignrole "
it will create a folder with the cvs informations (no need of a cvs server or supermachine, just about any computer will be able to do this).
Next you can apply your patch, either with tortoiseSVN gui (right click on the .patch file and > apply patch), or via command with "patch autoassignrole.module mypatch.patch"

This may seem a bit more complicated than just replacing file but it's essential for maintenance, and whoever accept to use this workflow will make the maintenance of a module much more painless.

If you really don't want to do this, so you should wait until a commit has been done, and a new dev version is available in the homepage.

I posted a rar file here http://benjamin.kuperberg.fr/download/autoassignrole.rar , but don't expect the community to do that each time, because it's exactly the opposite of what drupal workflow's is about.

Also, remember that as drupal 7 is still fresh and modules are being ported now, you have to know your position in this process : are you a developer and want to help the community ? in this case the first step is to learn how to do so. Or are you a user, and in this case you have to be patient and keep a look on the dev versions.

For this issue, i don't really know why this is not commited yet, you might want to send a message to the maintainer to see what's going on.
I changed the issue status, this may make things move.

Have a nice day,
Ben

First Ben thanks very much for the information and the rar post. I have downloaded but not tested yet. Also thanks for your undeserved vote of confidence… “it's really not a big deal to setup a checkout”. I laughed for 10 minutes reading your simple instructions. Like how in the hell would I have ever come up with “cvs -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -d autoassignrole -r DRUPAL 7--1 contributions/modules/autoassignrole”? I mean it is so logical and straightforward … not!

Anyway I am in the process of giving it all a try and the first thing I stumble upon is the cygwin installation process. Cygwin itself is easy to find http://cygwin.com/ but the installation process offers a list of 30 or so categories of Packages to select from and each category has additional options, several hundred in all. I am assuming your “cvs (cvs & patchutils) and git” options are in there somewhere, but I have not been able to locate them.

If you could provide a bit more detail on the process I (and I am sure many others) would be appreciate it.

As for me, I am new to Drupal (started in Nov. last year), not a programmer, and not really a web developer, completely self-taught out of necessity, trying to build a new project for my foundation (www.ffcg.org). I started learning Drupal 6 but by mid Jan i decided it was better to start on the newest version even though it will be less stable for a while. The good news is that working your way through the problems is a great learning process.

Hope things are well in France. I spent a couple years (03-04) working of the Mar (a houseboat near the Pont des Invalides). Good duty, great food, but the commute (from the US) was a pain.

Merci for your consideration.

Hi,
ok, good start, you won't regret digging into drupal's community workflow.
Firstable, i didn't say you could find it by yourself, but i just pointed out that the actual process of working with cvs is not as complex as we could be afraid of.
In the 10 min of laughing you gave to yourself, you could have taken 2 or 3 to search a bit on the drupal website "how the hell could i contribute to modules" ? And as drupal is almost as mush your friend as google is, it would have gently showed you that http://drupal.org/node/321 book page, which is the magic place where i got this so nerdy command line.

As for cygwin, the installation program offers a pretty filter box where you can type pretty much what you want, but i strongly suggest to type "cvs" if you're search for cvs, and as weird as it can be, typing "patch" will eventually show you the patch utils.

I don't think this is the right place for this discussion, and i recommend you to search over drupal book's pages, you'll find almost all the informations you need to do this.

Just few things to not loose too much time : cvs checkout is for working on module, cvs export is for getting the latest cvs revision without the CVS entries (e.g. all the files related to cvs revisionning). It's better to not put a checkout folder on your website, so work locally with this folder and upload to your ftp just the files you need.

It's great in France, we can almost feel the spring coming :)

Ben

Thanks Ben I appreciate the long distance tutoring, I will try it tomorrow. 70 in Las Vegas, sun shines most every day, but the food isn't as good as France. Well that is not true in my case, as my waistline shows; my wife is Chinese so i get honest Chinese food every day, not the Americanized stuff you get at restaurants. I will keep you posted on progress.

The patch mentioned in #21 (and i downloaded from #24) appears to be working for me. Can we expect a commit?

Works for me.

Hey Ben,
good looking patch! I should have checked the issues before starting work, just updated the module to include similar functionality but I didn't include the Profile2 module, good call on that.

I'm having trouble applying the patch though. I'm working from the Feb 25 dev version but it says the lines don't match up. What version did you create the patch from?

Also, I don't have a tonne of experience developing in drupal either as was curious how long it took you to make the necessary modifications to the .admin.inc and .module file?

Thanks,
Pete

I have role called 'Company' with a Profile2 attached. When I go to /user/register/Company I get this error:

"Warning: Invalid argument supplied for foreach() in form_type_checkboxes_value() (line 2209 of --/includes/form.inc)."

And the fields for the custom profile don't show up. However they do show up when I add administrator as an option, but the error remains.

Also I initially selected "Single Role" and "Radio Buttons / Checkboxes". But then I just ended up with 1 radio button, and states.js giving errors. Obvious to me now I needed to select Multiple roles (for my 1 role), but a bit unintuitive at first.

Maybe the PHP error is related to only having one options for Multiple roles?

Great patch otherwise!

Maybe disregard my last post, seems like its more of a problem in form.inc not copying simple default values over properly.

I have to say I'm with @tgriswold on this one! If there is anyone out there that can help, please do! :)

#17: autoassignrole-983612-2.patch queued for re-testing.

#21: autoassignrole-983612-3.patch queued for re-testing.

I've tried to use the feature that work with the profile2 module.
The problem I encountered was that in the registration form, I used the url to specify a role, instead the the other profile fields that should be hiding, the the block for the auto assign role disappeared, and all of the profile fields are on the form

I am wondering if anyone has tested and had the same problem...

EDIT: the permission setting was set to each role can edit own profile, and in the profile2 module, the profile types were set to appear in the registration form

#21: autoassignrole-983612-3.patch queued for re-testing.

Is the UI fix in the feb 25 update? The ui for selecting a role does not display on the registration page. However the auto assign function does work. Also that addition to integrate with profile 2 would be very helpful.

Feb 25th was just the git migration - cyberswat hasn't made a commit in a long time now (28 weeks).

I suspect an additional maintainer is required.

For a current Dv7 novice like me, could you describe what one needs to do to get your AAR patch working for now, even if it is a 'temp' option until the official AAR is released. (personally I work on an Ubuntu WebDev [without xxamp/wamp] sandbox and can just trial and error 'paste' into the D7 sites DIR).

With AutoAssignRole not working functionally in Drupal 7, can you advise on what might be an alternative for such a multi-user signup process or how one can use the 'patched' AAR for now? I'm not bothered what the workflow is just as long as people can sign up. I can always impliment AAR later if need be. 6 months is a long time to wait for an AAR Dv7 upgrade.
Thanks in advance for your efforts.

PB, UK

The patches are really easy to apply with TortoiseSVN in Windows. Once TortoiseSVN is installed you just right click on the patch file (inside Windows Explorer) and select 'apply patch'. Then you tell the program where the file you want to patch is (the files that the patch needs to change are listed inside the patch). This works for me since I can then upload the patched files to my server.

I couldn't get this to work with this particular patch (I think the patch was based on an slightly older version of AAR). Luckily ben kuper posted the patched files (see #24). I just downloaded those files and then uploaded autoassignrole.admin.inc, autoassignrole.module, and autoassignrole.test to my server.

I was also having problems using LoginToboggin with AAR (LoginToboggin would override the role that had been selected by AAR). I fixed this by changing the weight of the AAR module to 1. Since LoginToboggin has a weight of 0 this allows AAR's changes to have priority over LoginToboggin.

You can update a module's weight by going into the system table and looking for the entry for the Auto Assign Role module. In the weight column, change the number to 1. You can also change it by using the Util module once it is ported to D7.

I'm running on 100% pure Linux Ubuntu sandbox without XXAMP/WAMP, just good old LAMP (don't do Micro$oft anymore, had enough teaching that in university college for 10 years!, don't touch anything M$ nowadays if I can help it).
(-;

Can't they just be dropped in to the D7 'site's module DIR?
I'm sure I could try, if it don't work I'll just put back to old AAR module release.
PB

#17: autoassignrole-983612-2.patch queued for re-testing.

Tried applying patch using command line patch -p0 < filename.patch and it failed in two places.

Anyone have a working file on this, tried figuring out tourtoisesvn as advised above but can't seem to get that working either.

Thanks

can you tell me how you applied your patch, I have tried command line through putty also tortoisesvn and nothing seems to work with this patch. Do you have your corrected files you could possibly post?

I never got this patch to work, but there are files which have already been patched (see #24). I downloaded these and saved them in my drupal install and it works great.

Could somebody post a new link to the #24 files as the link doesn't seem to work any more ? Thanks a lot.

I sort of have the D7 AAR working in D7 (linux local sandbox), but when I try a 'test' registration with the 3 roles instead of ensuring that ONLY 1 role is matched, it registers 3 roles on the new registration user when I obviously only want the new user to have 1 role (1 being free, the 2 others are for users to pay via UB_subs) I'm using UberCart roles also, could this be a conflict?
Anyone know why this is??
[';']

PB

The patch can't be applied anymore because it was made for a previous version of the module.
The files in #24 that are already patched are also for this version, and should not be replacing the new version's files. Of course it may work, but there is high chances that other strange behaviours or bugs appear by doing that.
I've no time right now to port the patch to the new version, and the maintainer can take the current patch and commit it to the new version.
While new commits are done without integrating this bug, patches or filepacks won't be the real solution as they will need to be changed each time a new version is out.

Ask the maintainer to do something about that, i'll try to post a new patch when i get more time.

I REALLY don't want to fork this......but I really need this module. So I applied the patch to the latest dev manually (line by line using a text editor - since the latest dev is out of date with the patch). The full working package can be downloaded in the attached zip.

Thanks a lot Paulgemini for making this available :-)

paulgemini; forking is sorta encouraged now. You can make a quick sandbox project to fork contrib modules. I use those when handling multiple patches.

To those acting for fully working versions of patched file; there are plenty of guides you can find, including on drupal.org, on how to apply a patch. It's not hard. Patches can even be applied manually, ie without any tools. Try IRC, support forums, etc. for these issues though; this type of discussion make trying to find the current state of the issue hard, as have to wade through that mess that doesn't contribute to fixing the issue.

I'm go work on a patch based on what the d6 version does, possible in a sandbox. The current patch being tested appears to have issues with it, including a new feature. New features should be developed in their own issues.

Oh, trying to clarify the title; it's not just the UI, the functionality [excluding the settings form] is just not there.

Attached is a simple patch. It purely is addressing the choices that the current d7 module exposes, and not any new features, ie the other patch has more features than this.

The sandbox where added the patch is http://drupal.org/sandbox/hefox/1214268, but working on some other patches also there including some features.

Right, testbot likes the a/ and b/ now.

subscribe

I used the code in #51. It selects the radio correctly but doesnt really assign the role.
I really need this feature.

Tried locally the #51, works perfectly for me.
Please be more precise when describing your problem : what are the settings you use in the module ? what possibly conflicting other modules are installed ? do you use the profile2 feature ?

My setup is a fresh drupal 7.4 install with only the modded module from #51, tested both user assigned role with approval needed and no approval needed, both work as expected.

The real problem here is that no maintainer has commited this in time, and the whole discussion since the first patch wouldn't be necessary if this issue was followed more accurately by a maintainer (where are you cyberswat ? :) ). And as soon as a new dev version of the module is out, the files posted here will need to be changed again.

Yup. Sorry I didn't create the sandbox, but I'm still a bit wary of forking this. Would rather see it patched up against the current version and committed.

Sorry...
It worked at another site.
The one not working uses logintoboggan.
Both use profile2.

+1

#56: autoassignrole_983612_userchoice_registration_2.patch queued for re-testing.

+1

+1

The website I am preparing needs users to be able to specify whether they are students, alumni, or faculty, so that content can be adjusted to their role. Once the D7 "choose role" is working, we should be good to go.

Trying to figure out history of module and how best to do patches.

My current patch reflects #937434: User creates account from the web and is assigned roles based on interface selctions. Can we get a review of that then move onto profile2/path based like integration, aka #937434: User creates account from the web and is assigned roles based on interface selctions?

After applying patch I tried to register with role selection and got:

Fatal error: Unsupported operand types in Z:\home\paris9.kz\www\emploi\sites\all\modules\autoassignrole\autoassignrole.module on line 87

Duh, here try this.

hefox, seems ok now, thank you for quick fix!

How to use this patch? I really have no idea i hope someone can help me out.

If you're not sure how to apply any patch, please use google or check out drupal.org's patch documentation, IRC, or support forums.

If you're having troubles with this specific patch (applying the patch, etc.), please detail the problems

If you're having troubles using the functionality, please say what you're confused about.

#51 worked for me too, I now can see User choices at registration page.

With this version I get two bugs:

1. the sorting (Ascending/Descending) isn't saved (no button checked after validation)
2. User Role Description doesn't show right

• Is there a way to manage fields display? because User choice field does'nt appear in the display management of users registration.
• Is there a way to use Conditional Fields module with Allow user to choose? User choices fields doesn't appear in the list of choice of Conditional Fields

Could you elaborate on 2?

bullet 2) User roles isn't a fields 'field' type so it wouldn't
bullet 1) ditto, though there's ways to get it to semishow; that'd likely be a better as a feature request after patch.

Was using wrong variable somehow

Still not sure what description doesn't show right means, but putting back as needs review.

I didn't test the patch yet, but instead of a text in the description, only a number was shown.

which version of file should I patch?
I tried patch the #51 version and get errors

hunked #1 failer at 117
hunked #2 failer at 137

I tested the patch from the original version, it works fine.

To confirm, when you tested patch 72, the description showed as numeric, or were you testing one of the previous patches? I was not able to reproduce any description issues with that patch.

I'm looking for reviews on patch 78, which is the latest patch in the queue, and is often the case, the one to test.

I didn't succed to apply patch #72. I had error messages.
So I used the #51 version which has the bug I described.
I succefully patched the original files with #78 that works fine for me.

Enough reviews that it seemed best to push this patch and deal with any bugs in separate issues. Please redirect attention to #971320: Administrator configures registration paths, each with customised role assignments for registration path discussion/etc.

http://drupalcode.org/project/autoassignrole.git/commit/b3c1d51a00802a7b...

Until last week I was seeing the select role box fine but now it's gone! :S Can someone help me! It's urgent! I tried uninstalling and reinstalling the module but seems like the module doesn't uninstall properly so I have to manually delete the files and all my settings showed again when I reinstalled because I didn't touch the db.

Update: Its Drupal for Facebook - Registration module fault. More info here: #1887302: Drupal for Facebook interferes with Auto Assign Role & Apply for Role modules

Closed a duplicate: #1430358: Problem with Drupal 7.12 core

This was fixed back in 2011.

Closing this to clean up the issue queue as 7.x-1.0-beta1 was released.