Module does not load pattern from configuration

Not totally sure about conventions here, but I struggled to have quantumized's patch apply alongside another, useful one: https://www.drupal.org/node/2918391 due to differences in patch formats.

If I reapply the patch above against 8.x-1.x with `git format-patch` then they both apply cleanly. I've uploaded the output to here, but it probably shouldn't be credited to me if it's committed into the next release.

Thank you very much!

This patch solved my problem!

With either patch, the username is correctly set, but I get the following error:

Warning: Invalid argument supplied for foreach() in Drupal\auto_username\Form\AutoUsernameSettingsForm::autoUsernameCleanTokenValues() (line 436 of modules/contrib/auto_username/src/Form/AutoUsernameSettingsForm.php).
Drupal\auto_username\Form\AutoUsernameSettingsForm::autoUsernameCleanTokenValues('[user:mail]') (Line: 402)

autoUsernameCleanTokenValues() seems to be expecting an array but according to the stack trace is being passed the raw value of auto_username.setting.aun_pattern - "[user:mail]" - as a string… am I missing something obvious?

(core 8.5.5, php 7.1.18)

[incorrect stuff removed]

EDIT Completely misunderstood this, sorry. I misread #3 as suggesting the patches had been combined.
#2918391: Incorrect callback given to token replacement in autoUsernamePatternprocessor fixes the warning in autoUsernameCleanTokenValues() I mentioned in #5 (that error didn't show up immediately for me, hence my confusion.)

TL;DR: if you're using composer, you could do this:

        "patches": {
            "drupal/auto_username": {
                "Module does not load patern from configuration": "https://www.drupal.org/files/issues/2904513-fix-to-load-pattern-config-with-author-info.patch",
                "Incorrect callback given to token replacement in autoUsernamePatternprocessor": "https://www.drupal.org/files/issues/auto_username-2918391-2.patch"
            },

...

(Hide useless patch, add callback as related issue, fix typo in issue title)

#8 works fine

@@ -431,7 +433,7 @@ class AutoUsernameSettingsForm extends ConfigFormBase {
    *   An array of token replacements that need to be "cleaned".
    */
   public static function autoUsernameCleanTokenValues(&$replacements) {
-    foreach ($replacements as $token => $value) {
+    foreach ( (array) $replacements as $token => $value) {
       $replacements[$token] = self::autoUsernameCleanstring($value);
     }
   }

Edit: This change is unncessary and unrelated, given the fix in #2918391

Patch #3 is good to go.

Patch in #3 works well, but there is a warning when applying the patch:

git apply 2904513-fix-to-load-pattern-config-with-author-info.patch
2904513-fix-to-load-pattern-config-with-author-info.patch:22: trailing whitespace.

warning: 1 line adds whitespace errors.

Thank you, #14 works well.

for me tokens were not getting loaded... did below and it worked for me... Hope this helps someone....
FileName -> AutoUsernameSettingsForm.php
Function -> autoUsernamePatternprocessor
- $pattern = \Drupal::state()->get('aun_pattern', ''); -> Remove this line
+ $pattern = \Drupal::config('auto_username.settings')->get('aun_pattern'); ->Add this line

Cheers.

Yeah, config wasn't getting loaded for anything. This patch expands on the patch from #14 to include the rest of the config calls.

The last patch in #2895214: Misuse the State API fixed the problem for me. Several problems, same cause?

#17 worked well for me.

Minor bug still after applying this patch: usernames are being updated on user accounts edits when this functionality is disabled in the module config.

Committed, with an additional fix for point made by @thomasmurphy.