Hi
Fixed the following drupal standard issues -
Doc comment short description must end with a full stop - 72
Expected 1 space(s) before asterisk; 2 found - 125
Expected 1 space(s) before asterisk; 2 found - 126
Expected 1 space(s) before asterisk; 2 found - 127
Expected 1 space(s) before asterisk; 2 found - 128
A comma should follow the last multiline array item. Found: ) - 166
Functions must not contain multiple empty lines in a row; found 2 empty lines - 188
Case breaking statements must be followed by a single blank line - 226
Return comment must be on the next line - line 127 - Added a comment for the return statement.

CommentFileSizeAuthor
#6 drupal_standard_fixes-2582863-6.patch8.49 KBaburke626
#2 Automatic_Nodetitles-Drupal_standard_fixes-2582863-2.patch2.2 KBnupur.lohokare
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nupur.lohokare created an issue. See original summary.

nupur.lohokare’s picture

nupur.lohokare CreditAttribution: nupur.lohokare commented
Status: Active » Needs review
FileSize
Automatic_Nodetitles-Drupal_standard_fixes-2582863-2.patch2.2 KB
nupur.lohokare’s picture

nupur.lohokare CreditAttribution: nupur.lohokare as a volunteer and at Faichi Solutions Pvt Ltd commented
gaurav.bajpai’s picture

gaurav.bajpai CreditAttribution: gaurav.bajpai as a volunteer and at Faichi Solutions Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community

Hi nupur.lohokare,

Applied your patch and found indentation issues are valid in auto_nodetitle.module file.

Thanks!!

nupur.lohokare’s picture

nupur.lohokare CreditAttribution: nupur.lohokare as a volunteer and at Faichi Solutions Pvt Ltd commented
Assigned: nupur.lohokare » Unassigned
aburke626’s picture

aburke626
she/her
Primary language English
Location Harveys Lake, PA, US
CreditAttribution: aburke626 at Chromatic commented
FileSize
drupal_standard_fixes-2582863-6.patch8.49 KB

Updates all code standards issues, including those in the previous patch.

Coder has some issues with the code in the README - I'm not certain how to best fix that to please coder, but the code itself isn't an issue.

aburke626’s picture

aburke626
she/her
Primary language English
Location Harveys Lake, PA, US
CreditAttribution: aburke626 at Chromatic commented
Status: Reviewed & tested by the community » Needs review
Utkarsh_Mishra’s picture

Utkarsh_Mishra CreditAttribution: Utkarsh_Mishra at OpenSense Labs for DrupalFit commented
Assigned: Unassigned » Utkarsh_Mishra
Status: Needs review » Reviewed & tested by the community

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Didn't entirely use this patch. Did a PHP code-sniffing and manual changes to fix coding standard issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.