Closed (fixed)
Project:
Automatic Entity Label
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Aug 2024 at 10:00 UTC
Updated:
7 Jul 2025 at 18:37 UTC
Jump to comment: Most recent
Comments
Comment #3
anybodyComment #4
ankitv18 commentedNext major pipeline is passing now ~~ Marking this one as RTBC
Comment #5
ankitv18 commentedValidate pipeline get fixed once this issue gets merged: https://www.drupal.org/project/auto_entitylabel/issues/3467643
Comment #6
anybodyComment #7
dqdAwesome work in here +1 @ankitv18 thanks! Can please use issue tags like [#issuenumber] for better readability in your comments. Thank you.
Comment #8
ankitv18 commentedSure @dqd, actually @anybody already mentioned that in the related issue.
By the way, pipelines are clean now ~~ please proceed with the merge.
Comment #9
dqdAwesome work done in all these issues here @ankitv18! Very much appreciated. +1
PS: Related to the other merged issue, make sure the boxes for your credit are ticked. I did it now for you and I hope it will keep being added to the merge. I have conversation now on Slack what's going with the credits. We already had it on D.O. that it didn't work times before.
Comment #10
dqdComment #11
ankitv18 commentedThanks really appreciated ~~ happy to contribute more
Comment #12
ankitv18 commented@dqd Can we merge this one and move things ahead?
Comment #13
dqd@anktiv18: planned. That's why the proper title change and see comment #9
I need to clarify the issue with the credits otherwise you will complain missing credits again ;-)
So please stay calm.
Comment #14
ankitv18 commented:D Actually when you merge the issue that will only merge over the codebase but I guess maintainer do manually check the checkboxes to whom they want to credit before updating the status to fixed.
Comment #15
dqdIn this case here the check boxes keep being ticked. That was what I was after in one of my previous comments, because we had scenarios already on D.O. where these didn't kept being ticked. So that was not the issue. When I use the console to merge
... and push from there it usually works. Or when I use the traditional way of git clone and push. It only does not work when merging via Gitlab UI. Which I didn't know because I usually work on console only. Yesterday I was on the road while merging, so I used the UI.
Comment #16
dqdComment #17
dqdComment #19
dqdThanks at all! +1
Comment #21
liam morlandThis dependency should be updated to allow
book2.0."drupal/book": "^1.0 || ^2.0"