Problem/Motivation

The book module is contrib in Drupal 11.

Must be added as dev-dependency to the composer.json
The .info.yml entry needs to be checked

https://git.drupalcode.org/issue/auto_entitylabel-3467643/-/jobs/2516689

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

anybody created an issue. See original summary.

anybody’s picture

Issue summary: View changes
Status: Active » Needs review
ankitv18’s picture

Status: Needs review » Reviewed & tested by the community

Next major pipeline is passing now ~~ Marking this one as RTBC

ankitv18’s picture

Validate pipeline get fixed once this issue gets merged: https://www.drupal.org/project/auto_entitylabel/issues/3467643

anybody’s picture

Related issues: +#3467643: Fix PHPCS & cspell
dqd’s picture

Awesome work in here +1 @ankitv18 thanks! Can please use issue tags like [#issuenumber] for better readability in your comments. Thank you.

ankitv18’s picture

Sure @dqd, actually @anybody already mentioned that in the related issue.
By the way, pipelines are clean now ~~ please proceed with the merge.

dqd’s picture

Awesome work done in all these issues here @ankitv18! Very much appreciated. +1

PS: Related to the other merged issue, make sure the boxes for your credit are ticked. I did it now for you and I hope it will keep being added to the merge. I have conversation now on Slack what's going with the credits. We already had it on D.O. that it didn't work times before.

dqd’s picture

Title: Book module is now contrib » Book module contrib now - needs to be added to composer.json
Category: Bug report » Task
ankitv18’s picture

Thanks really appreciated ~~ happy to contribute more

ankitv18’s picture

@dqd Can we merge this one and move things ahead?

dqd’s picture

@anktiv18: planned. That's why the proper title change and see comment #9

I need to clarify the issue with the credits otherwise you will complain missing credits again ;-)

So please stay calm.

ankitv18’s picture

:D Actually when you merge the issue that will only merge over the codebase but I guess maintainer do manually check the checkboxes to whom they want to credit before updating the status to fixed.

dqd’s picture

In this case here the check boxes keep being ticked. That was what I was after in one of my previous comments, because we had scenarios already on D.O. where these didn't kept being ticked. So that was not the issue. When I use the console to merge

git remote add auto_entitylabel-3469652 git@git.drupal.org:issue/auto_entitylabel-3469652.git
git fetch auto_entitylabel-3469652

... and push from there it usually works. Or when I use the traditional way of git clone and push. It only does not work when merging via Gitlab UI. Which I didn't know because I usually work on console only. Yesterday I was on the road while merging, so I used the UI.

dqd’s picture

Title: Book module contrib now - needs to be added to composer.json » Issue #3469652 by anybody, ankitv18: Book module is contrib now and needs to be added to composer.json
dqd’s picture

Title: Issue #3469652 by anybody, ankitv18: Book module is contrib now and needs to be added to composer.json » Book module is contrib now and needs to be added to composer.json

  • dqd committed c08d5b64 on 8.x-3.x authored by anybody
    Issue #3469652 by anybody, ankitv18: Book module is contrib now and...
dqd’s picture

Status: Reviewed & tested by the community » Fixed

Thanks at all! +1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

liam morland’s picture

This dependency should be updated to allow book 2.0.

"drupal/book": "^1.0 || ^2.0"