Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The port is underway and there is some basic "working" code attached as a tarred module file in the issue. This will be committed to the 8.x branch as soon as it is cleaned up a bit more and the test/temporary code removed.
ORIGINAL POST:
This is just to announce my intent to do this. I haven't actually started, yet, and I'm not sure when I'll be committing code. I just wanted to put this out there in case anyone else gets the idea to do it so they touch base with me and make sure we aren't duplicating efforts. Please don't ask for ETAs. I intend to start coding tomorrow but Drupal 8 is drastically different so I have no clue how long it will take. :)
| Comment | File | Size | Author |
|---|---|---|---|
| #25 | port_author_pane_to-2339651-25.patch.patch | 4.78 KB | Sharique |
| |||
| #20 | author_pane_8_20151108.tar_.gz | 4.39 KB | Michelle |
Comments
Comment #1
MichelleIn case anyone is wondering, I do still plan to do this. I'm just trying to restructure my life to have contrib time on top of full time work and a family to care for on top of health issues and so far contrib is losing out. At some point, in theory, I should have a little contrib time at my job so that will help.
Comment #2
Scyther CreditAttribution: Scyther commentedIt would be nice to have a Drupal 8 module of this. So I would like to contribute also.
I will try to get a 8.x branch and then we can start :)
Comment #3
Scyther CreditAttribution: Scyther commentedCreated a branch for development for D8.
Comment #4
MichelleIf you want to work on it, don't wait on me. I keep wanting to get started and then am just not able to. Don't want to hold anything up on my account.
Comment #5
Scyther CreditAttribution: Scyther commentedNot so sure how to build a great D8 module, so if we could help each other out with some ideas and if there is a better way to do things, it would be nice :)
I have created some issues here with questions and would like to have your input Michelle. I do not want to run over you, from the beginning your are the creator of this module.
Comment #6
MichelleI was planning to start with this: https://www.drupal.org/project/drupalmoduleupgrader . I don't know Drupal 8 all that well so this was going to be a learning experience for me. :)
Don't worry about moving past me, really. I have health issues and am really struggling to do anything with my brain once I'm done with work because I am so completely exhausted. That makes it very hard to do this even though I want to. So if you have the time and energy and want to move forward, go for it. I'll jump in when I can.
Comment #7
MichelleJust wanted to say that I have actually started working on this (5 months later... gah). I'll put a patch up in the next day or so with the work in progress. I can't guarantee a ton of progress because Drupal 8 is really kicking my behind. :( Despite hours of trying reading about and watching a video on the plugin system, I don't feel very enlightened. I agree with the comment in there that it makes sense to use plugins to gather the info bits from core and other contrib but I just don't have a very good idea of how that needs to work.
Comment #8
Scyther CreditAttribution: Scyther commentedI have a branch in the GIT here, that I have started to get something done. Have you looked at it?
Yes Drupal plugins seems to be something to use, but exactly how to use and do it is a good question :)
Comment #9
MichelleYeah, I started with your branch and I also (separately) did a fresh convert from D7 with DMU and I've been going thru comparing and making fixes to what you did. I didn't get real far... Honestly, I'm pretty lost in D8. I was going to try and get a bit more done before uploading a patch for you to have a look at. Yes, I know I have commit access but I'd like to have a second opinion when it comes to D8. LOL!
Comment #10
Scyther CreditAttribution: Scyther commentedIt good that you make a own conversion so we get at least two different way to do this, and hopefully we can combine the best of those two to one great D8 version :)
Comment #11
MichelleIt's not a separate port; I'm starting with your code and building on that. I ran DMU on the D7 version in a separate directory but I'm just using that for reference. I'm still working with your branch. No sense re-doing the work you've already done. :)
Comment #12
Michelle(just updating the title since I have a bunch of porting ones in my tracker)
Comment #13
Sharique CreditAttribution: Sharique commentedThis patch contains porting of block configuration form and form submit.
Comment #14
MichelleJust letting everyone know that I've had some time to work on this and have a bunch of stuff in progress. I was running into too many problems trying to re-arrange the existing code to match what's in my head so started over with a blank module and am pulling bits in as I need them. I'm not completely re-inventing the wheel because I'll still use a bunch of what's started but I wanted it in a cleaner space to work on it. Because of that, I can't really commit what I have in progress until I get a bit farther. So if anyone else decides they want to work on this, please let me know first.
@Sharique - Thanks for the patch. I'll have a look and see if it can be pulled into what I'm doing.
Comment #15
Sharique CreditAttribution: Sharique commented@Michelle happy hear you got some time to work on it. I could not figure how I can get the node context, to fetch the author info.
I think we can also split work in some child items like porting theme templates and plugins.
Comment #16
Sharique CreditAttribution: Sharique as a volunteer commentedUpdated patch with changes in D8 core. I'm trying to add node context using node.node_route_context service(NodeRouteContext class), but no success.
Comment #17
MichelleThanks for the update... I'm confused, though. I know I worked on this and made some progress but I don't see a patch from me or any commits. It's been a few months, now, and I don't remember how I left things. I could have sworn I had uploaded a patch. Hopefully I still have the work on my computer somewhere, though I imagine it's out of date by now. I'll see if I can find it and if any of it is still relevant.
Comment #18
Sharique CreditAttribution: Sharique as a volunteer commented@Michelle it look like you are too busy, can you post your patch or commit that, so I can take it forward from there.
Comment #19
MichelleI found my old code and it was against Beta 11. I"ve spent some time going thru it but it's still pretty rough and I don't want to commit it, yet. I have some contrib time this week so I'm going to make a push to get it usable. Next weekend, I'll commit what I have if it's in good shape or just pop it in a file on this issue if it's not. That way it won't get lost on my hard drive again. :)
Comment #20
MichelleI spent quite a bit of time on this over the weekend and have something that is "working" (heavy on the quotes). If you add an author pane and give it an id of "default_pane" and then add an author pane block, it will display the user name of UID 1 in the block. Doesn't sound terribly impressive but it means the whole chain of objects is working as expected and all the basic structure is there. There is still a _lot_ of work to be done but at least it's a start. :)
I'm hoping to keep moving on this and not put it away for months again but it's likely going to be over a week before I get back to it because our company retreat is this coming week so that's going to mean not much contrib time.
Once I have the test code cleaned out, I will commit this code to the 8.x branch. I just didn't want to do it while I had so much hardcoded in there.
Comment #21
MichelleComment #23
MichelleI didn't get the rewrite to the point I wanted to before committing but I decided I'd dragged it out long enough so just committed what I have. It's not in a usable state but hopefully I'll get it there soon. Marking this issue fixed as there is a branch so further work should be broken into their own issues.
@Sharique: I never did use your patch as I rewrote the module from scratch rather than changing what was there but I gave you credit, anyway, since you took the time to make one.
Comment #24
Sharique CreditAttribution: Sharique as a volunteer commentedThanks Michelle, I'll test it and will create issues/patches for further development.
Comment #25
Sharique CreditAttribution: Sharique as a volunteer commentedI did some work on it further, here is patch, it fixes few fatal errors.
In my opinion there is no need to create an entity for author pane, we just need to define new AuthorPane plugin type, which you already did. Creating entity added unnecessary complication and confusion.
Comment #26
Sharique CreditAttribution: Sharique as a volunteer commentedComment #28
MichelleI'm still pretty new to D8 and OOP in general so maybe it isn't needed but I don't know for sure. We'll see as we go along, I guess. I'll have a look at your patch either later today or next week. I've got some contrib time and plan to work on Author Pane.
Comment #29
MichelleI took a look at the patch and some of it looks good but some I'm not so sure on. It seems like you are hardcoding one use case and I want to keep AP flexible. I'm going to be working on AP tonight and I'll manually pick out the bits I want for now but, in the future, let's not put anymore patches on this generic issue. We have a D8 branch so please make separate issues and patches for each piece so I can more easily see what you are trying to do and discuss each change separately.
Comment #31
Michelle@Sharique: Ok, I went thru the patch and pulled out the fixes and committed those. The rest I am going to hold for now. I may end up using them but I'm not sure, yet. Setting this issue back to fix as the port is underway and we can use individual issues going forward. Thanks for the help!
Comment #32
Michelle@Sharique, FYI: https://www.drupal.org/node/2639378#comment-10691888