Unable to alter authcache_enum user key generation input.

Seems like the test-bot does not download all dependencies. Perhaps that works better on the dev branch.

Instead of renaming an existing hook, I'd prefer to introduce a new one. In fact I believe that the alter-hook is correct, since the data structure is very similar to the one from hook_authcache_key_properties. In contrast the hook invoked on top of the function is more like an info-hook. Therefore I'd rather rename that. It would even be possible to keep the old around for some time for compatibility reasons. E.g.:

if (!isset($info)) {
  $properties_info = module_invoke_all('authcache_enum_key_property_info');
  drupal_alter('authcache_enum_key_property_info', $properties_info);

  // Backwards compatibility.
  $properties_info += module_invoke_all('authcache_enum_key_properties');

  [...]

  drupal_alter('authcache_enum_key_properties', $info);
}

Thanks, looks good. About the second problem (base_root['choices'] being populated by only the active site), do you think there is a generic solution for that problem? Maybe try to retrieve a list of base URLs from the language module?

I do not have much experience with multilingual sites. Maybe something like this might work:

global $base_root;
$base_roots = array($base_root);
if (drupal_multilingual()) {
  foreach (language_list('enabled') as $language) {
    $options = array(
      'absolute' => TRUE,
      'language' => $language->language,
    );
    $base_roots[] = url('<front>', $options);
  }
}

array_unique($base_roots) // -> use that in the base root choices array.

Seems like the following code fragment works for prefix as well as domain based multilingual sites (tried it in a PHP block):

global $base_root;
$base_roots = array($base_root);
if (drupal_multilingual()) {
  $languages = language_list('enabled');
  foreach ($languages[1] as $language) {
    $options = array(
      'absolute' => TRUE,
      'language' => $language,
    );
    $base_roots[] = url('<front>', $options);
  }
}

var_dump($base_roots);

I wonder whether we need to add an option for https-links as well?

#9 only makes sense for domain based language negotiation. When using a path prefix, then the $base_root will stay the same. Also I'm wondering whether it is really desirable to always expire all the languages. If the expiry hook was fired after a node translation was edited, then it is likely that only pages of that language should be expired - at least by default.

With #6 it is possible to customize the behavior, so I'm tempted to just commit that and ignore the base root part. Any opinions?

Uploading #6 again to trigger a new test run after #2546624: Add test coverage for Authcache Enum API.

Add tests.

+++ b/modules/authcache_enum/authcache_enum.api.php
@@ -25,14 +25,28 @@ function hook_authcache_enum_anonymous_keys_alter(&$keys) {
+ * in the future. Use hook_authcache_key_property_info() instead.

Was upgrading something to test this out and I think this may be wrong?

Should this be hook_authcache_enum_key_property_info()?

Also once I fixed that, I got this error after saving.

Warning: Illegal string offset 'choices' in authcache_enum_user_keys() (line 94 of /authcache/modules/authcache_enum/authcache_enum.module).

Edit: this may because I had both hooks implemented...

This is looking pretty good and doesn't hurt having more tests:)

It got some language stuff working with this:

/**
 * Implements hook_authcache_key_properties().
 */
function M_authcache_key_properties() {
  global $language;
  return array('lang' => $language->language);
}

/**
 * Implements hook_authcache_enum_key_property_info().
 */
function M_authcache_enum_key_property_info() {
  $languages = language_list('enabled');
  return array(
    'lang' => array(
      'name' => t('Language support'),
      'choices' => array_keys($languages[1]),
    ),
  );
}

Thank you, and sorry for the delay.