authcache_builtin_expire_v2_expire_cache is a killer with locale on

@znerol I don't think expire module expands it into all variants.

ExpireAPI::processInternalPaths() takes in a $langcode for "Language code of object that is expiring."

That would be cool if we didn't need to call url() though I think my patch still stands on it's own as url() could get called a lot and should scale nicer.

I'm chipping away at this slowly but surely!

One thing I noticed that is along the lines of what you were suggesting in removing the url() call completely:

$wildcards comes in with no language prefix! but url() generates things like this:

path: "admin/config/content/formats/%"
url: "/us/admin/config/content/formats/%25"

And the wildcard it's trying to match against is this:
"admin/config/content/formats/%"

In my case all those keys are false... so it doesn't matter but it's still wrong. I guess that's a different issue we should look into why they are all false and if that is legit.

Possible quick win:

One quick win here may be to just bail early if the bin is already empty?

if (cache_is_empty('cache_page')) {
  return;
}

Actual CID samples:

Anonymous:

http://site.dev/ca
http://site.dev/ca/company-overview
http://site.dev/us/company-overview

Admin:

39cb994/ca/admin/config/content/formats/
39cb994/ca/admin/config/content/formats/full_html
21f93cc/us/admin/config/content/formats/
a714259/ca
a714259/ca/admin/commerce

Here's a possible solution... though not sure if it's the best...

Also since I gutted url() function I wonder if it would still work with domain based locale instead of prefixed like mine.

I'd like to help but TBH a bit lost at the next steps... Can I do anything to this patch to make it more in line or is it ok as is?

Something wrong with the testbot or branch tests? I had to tag a new release in commerce_discount to make testbot smarten up. FYI #2490991: Tests pass locally and not on testbot: commerce_discount

Edit: Oh the branch failed some tests that's why:
https://qa.drupal.org/pifr/test/512338

@znerol #14 throws a bunch of

Warning: parse_url() expects parameter 1 to be string, array given in authcache_builtin_expire_v2_expire_cache() (line 19 of authcache/modules/authcache_builtin_expire_v2/authcache_builtin_expire_v2.module)

$urls seems to be coming in the form ['path' => ['path' => 'user/1', 'query' => '']] from expire.

But I've got the patch from #2267305: Problem when clearing the cache of nodes using entity translation applied and if $include_base_url is not TRUE, it will send the array across like that, hmm. Thoughts @das-peter?

My mistake, that patch doesn't change that it just makes it more aware of other languages. @znerol back to you.

Edit: and to answer it may only be a viable solution if $include_base_url is true. Which is a bit silly if you ask me that you would get an array in one case and a string in another:S

Here's an interesting but confusing UI... compared to what it does with respect to authcache.

Created a follow-up over there to maybe resolve that.
#2549647: Expire url should have a consistent output instead of string or array depending on $include_base_url

Ok resolved that weird array thing. Man the help text on base url inclusion likely need improvement on expire as well. I have to read that like 5-6 times before I grasp what it's trying to say.

Anyways going to try #14

+++ b/modules/authcache_builtin_expire_v2/authcache_builtin_expire_v2.module
@@ -15,8 +15,15 @@ function authcache_builtin_expire_v2_expire_cache($urls, $wildcards, $object_typ
+        $cid .= '?' . $parts['query'];
...
+        $cid .= '#' . $parts['fragment'];

I've not had these scenarios yet but I've been using and testing with this patch and I think so yes.