Support from Acquia helps fund testing for Drupal Acquia logo

Comments

znerol’s picture

Status: Active » Needs review
FileSize
0 bytes

  • znerol committed 84330f8 on 7.x-2.x
    Issue #2353999 by znerol: Use identity operator instead of equality...
znerol’s picture

Status: Needs review » Fixed

  • znerol committed 1254254 on 7.x-2.x
    Revert "Issue #2353999 by znerol: Use identity operator instead of...
znerol’s picture

Status: Fixed » Needs review
FileSize
37.81 KB

Uh, patch was null bytes, that's why it did pass the tests :)

Status: Needs review » Needs work

The last submitted patch, 5: 2353999-identity-not-equality-4.diff, failed testing.

znerol’s picture

Status: Needs work » Needs review
FileSize
25.94 KB
11.32 KB

Let's take small steps:

znerol’s picture

Converted some more occurrences, those are mainly in test-code.

znerol’s picture

  • znerol committed e834de0 on 7.x-2.x
    issue #2353999 by znerol: Use identity operator (===) instead of...
znerol’s picture

Status: Needs review » Fixed

For reference, use the following grep to locate the remaining occurrences. They mostly are found in function/methods copied over from core. Also some of them are integer constant on the right side which should be safer than string.

find * -type f -not -name '*.api.php' -not -name '*.js' -not -name '*.vcl' -not -name '*.vtc' -not -name '*.txt' -not -name 'Makefile' | xargs git grep '[^=!][=!]=[^=!]'

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.