Problem/Motivation

After updating my site to Drupal 10.4.0 navigation menu is broken.

The menu style is different depending of the page:

1. If it's a view page or node type "Page", menu style is accordion and always open no matter of the screen width.
2. If it's a node type "Blog entry", then navigation menu breakpoints works reversed.
For example if I set default style Mega Nav and mobile style Off Canvas, it's reversed - Off Canvas is default, Mega Nav is mobile.

Moreover, an error messages are displayed:

Deprecated function: Creation of dynamic property Drupal\at_core\Layout\Layout::$layout_path is deprecated in Drupal\at_core\Layout\Layout->__construct() (line 27 of themes/contrib/at_theme/at_core/src/Layout/Layout.php).


Deprecated function: Creation of dynamic property Drupal\at_core\Layout\Layout::$layout_cid is deprecated in Drupal\at_core\Layout\Layout->__construct() (line 28 of themes/contrib/at_theme/at_core/src/Layout/Layout.php).

If I'm logged in the responsive menu works as expected, because I have Admin_toolbar extension installed.

My Php version is 8.3.8

Steps to reproduce

Install Adaptive Theme 2.0.1
Create new subtheme using AT_Tool.
Enable Responsive menus.

Comments

urix created an issue. See original summary.

urix’s picture

urix commented
Issue summary: View changes
urix’s picture

urix commented
Issue summary: View changes
bigtomfelix’s picture

bigtomfelix commented

I confirm, the problem is for anonymous users, if you log in the problem disappears. You can see that the problem arises from reading the js files for anonymous. Errors on at-core theme and at- breakpoint

bsnodgrass’s picture

bsnodgrass commented

Reverting back to 10.3.11 (released yesterday) Solved our issue.
We have another site using this theme, which does not have this issue with 10.4.0.

We will be upgrading that site to 10.4.1 (also released yesterday) as we work on this.

The version of AT Core is different in the subtheme for each site. I will post more later as we follow this up.

Added related Issue.

piroth’s picture

piroth commented

I also confirm that the problem appears after an upgrade to 10.4.x and is not present in 10.3.11 I've got other sites with other themes and there is no problem with those sites.
I confirm also that it is only for anonymous... well, all the symptoms described in #4 and #5 😎

urix’s picture

urix commented

I've contacted the module maintainer - there was no reply.

It seems like it's abandoned.

mattbloomfield’s picture

mattbloomfield commented

It's not abandoned, I haven't received anything. If you sent it, try again.

Other than that, is there a reason you haven't switched to Adaptive Theme?

urix’s picture

urix commented

Look at your inbox at https://www.drupal.org/u/mattbloomfield

And to the topic - what are you planning to do with this bug?
The only solution is to switch to another module?

bsnodgrass’s picture

bsnodgrass commented

Hello mattbloomfield, I also sent a message via the Contact form on D.O. (January 8, 2025 below), perhaps something is off on your profile?

bsnodgrass (https://www.drupal.org/u/bsnodgrass) has sent you a message via
your contact form (https://www.drupal.org/user/3620586/contact) at
Drupal.org.

If you don't want to receive such e-mails, you can change your settings at
https://www.drupal.org/user/3620586/edit.

Message:

Matt,

Thanks for your work on the at_theme and the older version (adaptivetheme).

We have two clients currently running at_theme, which seems to be the new
preferred option. We inherited these two sites from an independent developer
when she retired. I am doing some preliminary research to make some
recommendations to these clients as we work on an issue we experienced while
upgrading from 10.3.x to 10.4.x. I posted to the issue queue this morning.

I think it would be appropriate to post an issue regarding the plan for
3.0.x, but wanted to reach out to you first. It looks like you could use some
help. Personally, I am a site builder and can't help with the development
side, but I do have someone on our team who I might be able to get involved.
At the very least, if I knew more about your plan, I could maybe help triage
some of the support issues.

Bob Snodgrass
net2Community, Inc. St Charles, IL
bsnodgrass in the Drupal Slack and most places online
630-781-9883

electric.larry’s picture

electric.larry commented

Can you please check if the patch in #10 in issue #3498246 fixes the problem?

https://www.drupal.org/project/adaptivetheme/issues/3498246#comment-1595...

kniekel’s picture

kniekel commented

#11 worked for me eg on

https://www.vesperkirche-schweinfurt.de/
https://www.citykirche-schweinfurt.de/

Thank you so much!

adrianm6254’s picture

adrianm6254 commented

I was able to use the same patch mentioned in #11 to fix my site.

drupal_rogue’s picture

drupal_rogue commented

The patch from #11 fixed mine as well. Thanks all.

electric.larry’s picture

electric.larry commented

But be careful, use the patch from #14 instead of #11. I had to fix a problem with #11.

Also note that not all users could fix their sites with the patch.

adrianm6254’s picture

adrianm6254 commented

@electric.larry I tried patch from #14 first and it would not apply, but the patch from #11 applied for me.

mattbloomfield’s picture

mattbloomfield commented

This has made it's way into the new release.

urix’s picture

urix commented

Updating to 2.0.2 fixes the problem.

electric.larry’s picture

electric.larry commented
Status: Active » Reviewed & tested by the community

@mattbloomfield, I think we can mark this one fixed together with #3498246.

milan.durovic’s picture

milan.durovic commented

This seems to be related to the issue https://www.drupal.org/project/at_theme/issues/3495512
While the main menu problem is fixed and remains fixed even after the upgrade to Drupal 11, the other problem of all theme regions appearing in a single column regardless of the screen width is there after the upgrade to Drupal 11. The 7.1.1 version fixes that problem for Drupal 10.4.1, but not for Drupal 11.