Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
During profile installation, when apps module collects module information in app_manifest it calls function apps_add_app_info() which tries to load additional information about app from implementation of hook_apps_app_info(). But it could not do that, because module files are not included yet (without full bootstrap during installation process).
Comment | File | Size | Author |
---|---|---|---|
#3 | apps-manifest-2753413-3.patch | 1.08 KB | Jon Nunan |
#2 | app_manifest_could-2753413-2.patch | 771 bytes | berdyshev |
Comments
Comment #2
berdyshev CreditAttribution: berdyshev at AMgrade commentedHere is patch which fixes that
Comment #3
Jon Nunan CreditAttribution: Jon Nunan at Flight Centre Travel Group commentedI found when upgrading the Panopoly distro to 7.50 reading the remote apps manifest caused some errors here too. This is a pain for automated testing so I tried being a bit more defensive in looking for hooks while also including the logic from #2.
Comment #4
mpotter CreditAttribution: mpotter at Phase2 commentedI think this makes good sense based on the changed I've seen in 7.50. The system_rebuild_module_data() is cached so I don't see a performance downside and this improves the patch in #2 by only including the files if needed.
I'm going to RTBC this for Apps, but would still love to hear real experience from people using this patch in the wild.
Comment #5
dsnopekThis doesn't fully fix the problem in Panopoly. I suspect that we need a
drupal_static_reset('system_rebuild_module_data')
after downloading the apps in 'apps_profile_download_batch_finished()' or something like that, because we're trying to install an app that was just downloaded as part of the current "request" (in that everything in Drush is in the same "request").Comment #6
dsnopekSo, Panopoly's problem in #5 turned out to be an interaction between Apps, Search API and the new changes in Drupal 7.50, where it seemed that the best fix was in Search API, so... back to RTBC!
Comment #8
mpotter CreditAttribution: mpotter at Phase2 commentedCommitted to 8fea547.