During profile installation, when apps module collects module information in app_manifest it calls function apps_add_app_info() which tries to load additional information about app from implementation of hook_apps_app_info(). But it could not do that, because module files are not included yet (without full bootstrap during installation process).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

berdyshev created an issue. See original summary.

berdyshev’s picture

Status: Active » Needs review
FileSize
771 bytes

Here is patch which fixes that

Jon Nunan’s picture

I found when upgrading the Panopoly distro to 7.50 reading the remote apps manifest caused some errors here too. This is a pain for automated testing so I tried being a bit more defensive in looking for hooks while also including the logic from #2.

mpotter’s picture

Status: Needs review » Reviewed & tested by the community

I think this makes good sense based on the changed I've seen in 7.50. The system_rebuild_module_data() is cached so I don't see a performance downside and this improves the patch in #2 by only including the files if needed.

I'm going to RTBC this for Apps, but would still love to hear real experience from people using this patch in the wild.

dsnopek’s picture

Status: Reviewed & tested by the community » Needs work

This doesn't fully fix the problem in Panopoly. I suspect that we need a drupal_static_reset('system_rebuild_module_data') after downloading the apps in 'apps_profile_download_batch_finished()' or something like that, because we're trying to install an app that was just downloaded as part of the current "request" (in that everything in Drush is in the same "request").

dsnopek’s picture

Status: Needs work » Reviewed & tested by the community

So, Panopoly's problem in #5 turned out to be an interaction between Apps, Search API and the new changes in Drupal 7.50, where it seemed that the best fix was in Search API, so... back to RTBC!

  • mpotter committed 8fea547 on 7.x-1.x authored by Jon Nunan
    Issue #2753413 by berdyshev, Jon Nunan: app_manifest() could not call...
mpotter’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8fea547.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.